Request review and possible merge of tincho-osm.

[git.ikiwiki.info.git] / IkiWiki / Plugin / openid.pm

diff --git a/IkiWiki/Plugin/openid.pm b/IkiWiki/Plugin/openid.pm
index e3b9982f2d3bbf4d5185ae7a1b97c850f6cdaa89..35ef52a581e745a38d11b5d43a57d8dc4cab558e 100644 (file)
--- a/IkiWiki/Plugin/openid.pm
+++ b/IkiWiki/Plugin/openid.pm
@@ -7,31 +7,18 @@ use strict;
 use IkiWiki 3.00;
 
 sub import {
-       add_underlay("openid-selector");
-       add_underlay("jquery");
-       hook(type => "checkconfig", id => "openid", call => \&checkconfig);
        hook(type => "getsetup", id => "openid", call => \&getsetup);
        hook(type => "auth", id => "openid", call => \&auth);
        hook(type => "formbuilder_setup", id => "openid",
                call => \&formbuilder_setup, last => 1);
-}
-
-sub checkconfig () {
-       if ($config{cgi}) {
-               # Intercept normal signin form, so the openid selector
-               # can be displayed.
-               # 
-               # When other auth hooks are registered, give the selector
-               # a reference to the normal signin form.
-               require IkiWiki::CGI;
-               my $real_cgi_signin;
-               if (keys %{$IkiWiki::hooks{auth}} > 1) {
-                       $real_cgi_signin=\&IkiWiki::cgi_signin;
-               }
-               inject(name => "IkiWiki::cgi_signin", call => sub ($$) {
-                       openid_selector($real_cgi_signin, @_);
-               });
-       }
+       IkiWiki::loadplugin("emailauth");
+       IkiWiki::loadplugin("loginselector");
+       IkiWiki::Plugin::loginselector::register_login_plugin(
+               "openid",
+               \&openid_setup,
+               \&openid_check_input,
+               \&openid_auth,
+       );
 }
 
 sub getsetup () {
@@ -55,38 +42,34 @@ sub getsetup () {
                },
 }
 
-sub openid_selector {
-       my $real_cgi_signin=shift;
-        my $q=shift;
-        my $session=shift;
-
-       my $openid_url=$q->param('openid_identifier');
-       my $openid_error;
+sub openid_setup ($$) {
+       my $q=shift;
+       my $template=shift;
 
-       if (! load_openid_module()) {
-               if ($real_cgi_signin) {
-                       $real_cgi_signin->($q, $session);
-                       exit;
+       if (load_openid_module()) {
+               my $openid_url=$q->param('openid_identifier');
+               if (defined $openid_url) {
+                       $template->param(openid_url => $openid_url);
                }
-               error(sprintf(gettext("failed to load openid module: "), @_));
+               return 1;
        }
-       elsif (defined $q->param("action") && $q->param("action") eq "verify") {
-               validate($q, $session, $openid_url, sub {
-                       $openid_error=shift;
-               });
+       else {
+               return 0;
        }
+}
 
-       my $template=IkiWiki::template("openid-selector.tmpl");
-       $template->param(
-               cgiurl => IkiWiki::cgiurl(),
-               (defined $openid_error ? (openid_error => $openid_error) : ()),
-               (defined $openid_url ? (openid_url => $openid_url) : ()),
-               ($real_cgi_signin ? (nonopenidform => $real_cgi_signin->($q, $session, 1)) : ()),
-       );
+sub openid_check_input ($) {
+       my $q=shift;
+       my $openid_url=$q->param('openid_identifier');
+       defined $q->param("action") && $q->param("action") eq "verify" && defined $openid_url && length $openid_url;
+}
 
-       IkiWiki::printheader($session);
-       print IkiWiki::cgitemplate($q, "signin", $template->output);
-       exit;
+sub openid_auth ($$$$) {
+       my $q=shift;
+       my $session=shift;
+       my $errordisplayer=shift;
+       my $openid_url=$q->param('openid_identifier');
+       validate($q, $session, $openid_url, $errordisplayer);
 }
 
 sub formbuilder_setup (@) {
@@ -104,7 +87,6 @@ sub formbuilder_setup (@) {
                        size => 1, force => 1,
                        fieldset => "login",
                        comment => $session->param("name"));
-               $form->field(name => "email", type => "hidden");
        }
 }
 
@@ -119,7 +101,9 @@ sub validate ($$$;$) {
        my $claimed_identity = $csr->claimed_identity($openid_url);
        if (! $claimed_identity) {
                if ($errhandler) {
-                       $errhandler->($csr->err);
+                       if (ref($errhandler) eq 'CODE') {
+                               $errhandler->($csr->err);
+                       }
                        return 0;
                }
                else {
@@ -223,7 +207,7 @@ sub auth ($$) {
        }
        elsif (defined $q->param('openid_identifier')) {
                # myopenid.com affiliate support
-               validate($q, $session, $q->param('openid_identifier'));
+               validate($q, $session, scalar $q->param('openid_identifier'));
        }
 }
 
@@ -238,10 +222,10 @@ sub getobj ($$) {
        my $ua;
        eval q{use LWPx::ParanoidAgent};
        if (! $@) {
-               $ua=LWPx::ParanoidAgent->new;
+               $ua=LWPx::ParanoidAgent->new(agent => $config{useragent});
        }
        else {
-               $ua=LWP::UserAgent->new;
+               $ua=useragent();
        }
 
        # Store the secret in the session.