cherry-pick uri security fix

[git.ikiwiki.info.git] / IkiWiki / Plugin / recentchanges.pm

diff --git a/IkiWiki/Plugin/recentchanges.pm b/IkiWiki/Plugin/recentchanges.pm
index 9dad0af5e2787c35cd254f2772750864675ef94f..22f934f2e8becec79e9fc8dfae6f0f1ffbd90949 100644 (file)
--- a/IkiWiki/Plugin/recentchanges.pm
+++ b/IkiWiki/Plugin/recentchanges.pm
@@ -8,7 +8,9 @@ use IkiWiki 2.00;
 sub import { #{{{
        hook(type => "checkconfig", id => "recentchanges", call => \&checkconfig);
        hook(type => "refresh", id => "recentchanges", call => \&refresh);
 sub import { #{{{
        hook(type => "checkconfig", id => "recentchanges", call => \&checkconfig);
        hook(type => "refresh", id => "recentchanges", call => \&refresh);

+       hook(type => "pagetemplate", id => "recentchanges", call => \&pagetemplate);

        hook(type => "htmlize", id => "_change", call => \&htmlize);
        hook(type => "htmlize", id => "_change", call => \&htmlize);

+       hook(type => "cgi", id => "recentchanges", call => \&cgi);

 } #}}}
 
 sub checkconfig () { #{{{
 } #}}}
 
 sub checkconfig () { #{{{


@@ -26,18 +28,63 @@ sub refresh ($) { #{{{
        
        # delete old and excess changes
        foreach my $page (keys %pagesources) {
        
        # delete old and excess changes
        foreach my $page (keys %pagesources) {

-               if ($page=~/^\Q$config{recentchangespage}\E\/change_/ && ! $seen{$page}) {
+               if ($page =~ /\._change$/ && ! $seen{$page}) {

                        unlink($config{srcdir}.'/'.$pagesources{$page});
                }
        }
 } #}}}
 
                        unlink($config{srcdir}.'/'.$pagesources{$page});
                }
        }
 } #}}}
 

+# Enable the recentchanges link on wiki pages.
+sub pagetemplate (@) { #{{{
+       my %params=@_;
+       my $template=$params{template};
+       my $page=$params{page};
+       if ($config{rcs} && $page ne $config{recentchangespage} &&
+           $template->query(name => "recentchangesurl")) {
+               $template->param(recentchangesurl => urlto($config{recentchangespage}, $page));
+               $template->param(have_actions => 1);
+       }
+} #}}}
+

 # Pages with extension _change have plain html markup, pass through.
 sub htmlize (@) { #{{{
        my %params=@_;
        return $params{content};
 } #}}}
 
 # Pages with extension _change have plain html markup, pass through.
 sub htmlize (@) { #{{{
        my %params=@_;
        return $params{content};
 } #}}}
 

+sub cgi ($) { #{{{
+       my $cgi=shift;
+       if (defined $cgi->param('do') && $cgi->param('do') eq "recentchanges_link") {
+               # This is a link from a change page to some
+               # other page. Since the change pages are only generated
+               # once, statically, links on them won't be updated if the
+               # page they link to is deleted, or newly created, or
+               # changes for whatever reason. So this CGI handles that
+               # dynamic linking stuff.
+               my $page=$cgi->param("page");
+               if (!defined $page) {
+                       error("missing page parameter");
+               }
+
+               IkiWiki::loadindex();
+
+               my $link=bestlink("", $page);
+               if (! length $link) {
+                       print "Content-type: text/html\n\n";
+                       print IkiWiki::misctemplate(gettext(gettext("missing page")),
+                               "<p>".
+                               sprintf(gettext("The page %s does not exist."),
+                                       htmllink("", "", $page)).
+                               "</p>");
+               }
+               else {
+                       IkiWiki::redirect($cgi, $config{url}."/".htmlpage($link));
+               }
+
+               exit;
+       }
+}
+

 sub store ($$$) { #{{{
        my $change=shift;
 
 sub store ($$$) { #{{{
        my $change=shift;
 


@@ -52,14 +99,21 @@ sub store ($$$) { #{{{
        delete @{$change->{pages}}[10 .. @{$change->{pages}}] if $is_excess;
        $change->{pages} = [
                map {
        delete @{$change->{pages}}[10 .. @{$change->{pages}}] if $is_excess;
        $change->{pages} = [
                map {

-                       if (length $config{url}) {
-                               $_->{link} = "<a href=\"$config{url}/".
-                                       urlto($_->{page},"")."\">".
-                                       IkiWiki::pagetitle($_->{page})."</a>";
+                       if (length $config{cgiurl}) {
+                               $_->{link} = "<a href=\"".
+                                       IkiWiki::cgiurl(
+                                               do => "recentchanges_link",
+                                               page => $_->{page}
+                                       ).
+                                       "\">".
+                                       IkiWiki::pagetitle($_->{page}).
+                                       "</a>"

                        }
                        else {
                                $_->{link} = IkiWiki::pagetitle($_->{page});
                        }
                        }
                        else {
                                $_->{link} = IkiWiki::pagetitle($_->{page});
                        }

+                       $_->{baseurl}="$config{url}/" if length $config{url};
+

                        $_;
                } @{$change->{pages}}
        ];
                        $_;
                } @{$change->{pages}}
        ];


@@ -67,15 +121,16 @@ sub store ($$$) { #{{{
 
        # See if the committer is an openid.
        $change->{author}=$change->{user};
 
        # See if the committer is an openid.
        $change->{author}=$change->{user};

-       my $oiduser=IkiWiki::openiduser($change->{user});
+       my $oiduser=eval { IkiWiki::openiduser($change->{user}) };

        if (defined $oiduser) {
                $change->{authorurl}=$change->{user};
                $change->{user}=$oiduser;
        }
        if (defined $oiduser) {
                $change->{authorurl}=$change->{user};
                $change->{user}=$oiduser;
        }

-       elsif (length $config{url}) {
-               $change->{authorurl}="$config{url}/".
-                       (length $config{userdir} ? "$config{userdir}/" : "").
-                       $change->{user};
+       elsif (length $config{cgiurl}) {
+               $change->{authorurl} = IkiWiki::cgiurl(
+                       do => "recentchanges_link",
+                       page => (length $config{userdir} ? "$config{userdir}/" : "").$change->{author},
+               );

        }
 
        # escape  wikilinks and preprocessor stuff in commit messages
        }
 
        # escape  wikilinks and preprocessor stuff in commit messages


@@ -94,7 +149,6 @@ sub store ($$$) { #{{{
                commitdate => displaytime($change->{when}, "%X %x"),
                wikiname => $config{wikiname},
        );
                commitdate => displaytime($change->{when}, "%X %x"),
                wikiname => $config{wikiname},
        );

-       $template->param(baseurl => "$config{url}/") if length $config{url};

        IkiWiki::run_hooks(pagetemplate => sub {
                shift->(page => $page, destpage => $page, template => $template);
        });
        IkiWiki::run_hooks(pagetemplate => sub {
                shift->(page => $page, destpage => $page, template => $template);
        });