semi-review; any chance of tests?

[git.ikiwiki.info.git] / doc / bugs / Titles_are_lower-cased_when_creating_a_page.mdwn

diff --git a/doc/bugs/Titles_are_lower-cased_when_creating_a_page.mdwn b/doc/bugs/Titles_are_lower-cased_when_creating_a_page.mdwn
index f2c60309ba7df335c6c8f201380a20d0daaa7fac..351c2c1a141d640eb47b739c47f64407b1944c2d 100644 (file)
--- a/doc/bugs/Titles_are_lower-cased_when_creating_a_page.mdwn
+++ b/doc/bugs/Titles_are_lower-cased_when_creating_a_page.mdwn
@@ -4,17 +4,19 @@ If I click on "Czars in Russia", I'd like Ikiwiki to create "Czars\_in\_Russia.m
 
 > There's a simple patch that can do this:
 
-> --- a/IkiWiki.pm
-> +++ b/IkiWiki.pm
-> @@ -584,7 +584,7 @@ sub htmllink ($$$;@) {
->                      return "<span class=\"createlink\"><a href=\"".
->                              cgiurl(
->                                      do => "create",
-> -                                    page => pagetitle(lc($link), 1),
-> +                                    page => pagetitle($link, 1),
->                                      from => $lpage
->                              ).
->                              "\">?</a>$linktext</span>"
+<pre>
+-- a/IkiWiki.pm
++++ b/IkiWiki.pm
+@@ -584,7 +584,7 @@ sub htmllink ($$$;@) {
+                       return "&lt;span class=\"createlink\">&lt;a href=\"".
+                               cgiurl(
+                                       do => "create",
+-                                      page => pagetitle(lc($link), 1),
++                                      page => pagetitle($link, 1),
+                                       from => $lpage
+                               ).
+                               "\">?&lt;/a>$linktext&lt;/span>"
+</pre>
 
 > This is fine if you don't mind mixed or randomly cased filenames getting
 > created. Otoh, if the link happened to start a sentence and so had its
@@ -30,3 +32,6 @@ If I click on "Czars in Russia", I'd like Ikiwiki to create "Czars\_in\_Russia.m
 > Then, which one is the default wouldn't much matter. (The non-lower cased
 > one would probably be the best choice.) --[[Joey]]
 >> Either of your proposed solutions (make it the default or include both in the pop-up menu) sounds fine to me.  Which one is easier? :) --[[sabr]]
+
+>>> [[Done]]; it now defaults to the mixed case title and provides
+>>> the lower-case one as an option in the select box. --[[Joey]]