web commit by http://ptecza.myopenid.com/: * Bug report

[git.ikiwiki.info.git] / IkiWiki / Wrapper.pm

diff --git a/IkiWiki/Wrapper.pm b/IkiWiki/Wrapper.pm
index d723684463dda687e21be6d18341ce0c6ac0d1d5..90a4c46c79141419c872e2f64102658f41dcefda 100644 (file)
--- a/IkiWiki/Wrapper.pm
+++ b/IkiWiki/Wrapper.pm
@@ -3,7 +3,8 @@
 use warnings;
 use strict;
 use Cwd q{abs_path};
 use warnings;
 use strict;
 use Cwd q{abs_path};

-use Data::Dumper;
+use Data::Dumper ;
+use IkiWiki;

 
 package IkiWiki;
 
 
 package IkiWiki;
 


@@ -12,37 +13,27 @@ sub gen_wrapper () { #{{{
        $config{destdir}=abs_path($config{destdir});
        my $this=abs_path($0);
        if (! -x $this) {
        $config{destdir}=abs_path($config{destdir});
        my $this=abs_path($0);
        if (! -x $this) {

-               error("$this doesn't seem to be executable");
+               error(sprintf(gettext("%s doesn't seem to be executable"), $this));

        }
 
        if ($config{setup}) {
        }
 
        if ($config{setup}) {

-               error("cannot create a wrapper that uses a setup file");
+               error(gettext("cannot create a wrapper that uses a setup file"));

        }
        my $wrapper=possibly_foolish_untaint($config{wrapper});
        if (! defined $wrapper || ! length $wrapper) {
        }
        my $wrapper=possibly_foolish_untaint($config{wrapper});
        if (! defined $wrapper || ! length $wrapper) {

-               error("wrapper filename not specified");
+               error(gettext("wrapper filename not specified"));

        }
        delete $config{wrapper};
        
        my @envsave;
        push @envsave, qw{REMOTE_ADDR QUERY_STRING REQUEST_METHOD REQUEST_URI
                       CONTENT_TYPE CONTENT_LENGTH GATEWAY_INTERFACE
        }
        delete $config{wrapper};
        
        my @envsave;
        push @envsave, qw{REMOTE_ADDR QUERY_STRING REQUEST_METHOD REQUEST_URI
                       CONTENT_TYPE CONTENT_LENGTH GATEWAY_INTERFACE

-                      HTTP_COOKIE} if $config{cgi};
+                      HTTP_COOKIE REMOTE_USER} if $config{cgi};

        my $envsave="";
        foreach my $var (@envsave) {
                $envsave.=<<"EOF"
        if ((s=getenv("$var")))
        my $envsave="";
        foreach my $var (@envsave) {
                $envsave.=<<"EOF"
        if ((s=getenv("$var")))

-               asprintf(&newenviron[i++], "%s=%s", "$var", s);
-EOF
-       }
-       if ($config{svn} && $config{notify}) {
-               # Support running directly as hooks/post-commit by passing
-               # $2 in REV in the environment.
-               $envsave.=<<"EOF"
-       if (argc == 3)
-               asprintf(&newenviron[i++], "REV=%s", argv[2]);
-       else if ((s=getenv("REV")))
-               asprintf(&newenviron[i++], "%s=%s", "REV", s);
+               addenv("$var", s);

 EOF
        }
        
 EOF
        }
        


@@ -50,44 +41,83 @@ EOF
        my $configstring=Data::Dumper->Dump([\%config], ['*config']);
        $configstring=~s/\\/\\\\/g;
        $configstring=~s/"/\\"/g;
        my $configstring=Data::Dumper->Dump([\%config], ['*config']);
        $configstring=~s/\\/\\\\/g;
        $configstring=~s/"/\\"/g;

+       $configstring=~s/\n/\\n/g;

        
        

-       open(OUT, ">$wrapper.c") || error("failed to write $wrapper.c: $!");;
+       #translators: The first parameter is a filename, and the second is
+       #translators: a (probably not translated) error message.
+       open(OUT, ">$wrapper.c") || error(sprintf(gettext("failed to write %s: %s"), "$wrapper.c", $!));;

        print OUT <<"EOF";
 /* A wrapper for ikiwiki, can be safely made suid. */
        print OUT <<"EOF";
 /* A wrapper for ikiwiki, can be safely made suid. */

-#define _GNU_SOURCE

 #include <stdio.h>
 #include <stdio.h>

+#include <sys/types.h>

 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>
 
 extern char **environ;
 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>
 
 extern char **environ;

+char *newenviron[$#envsave+5];
+int i=0;
+
+addenv(char *var, char *val) {
+       char *s=malloc(strlen(var)+1+strlen(val)+1);
+       if (!s)
+               perror("malloc");
+       sprintf(s, "%s=%s", var, val);
+       newenviron[i++]=s;
+}

 
 int main (int argc, char **argv) {
        /* Sanitize environment. */
        char *s;
 
 int main (int argc, char **argv) {
        /* Sanitize environment. */
        char *s;

-       char *newenviron[$#envsave+5];
-       int i=0;

 $envsave
        newenviron[i++]="HOME=$ENV{HOME}";
        newenviron[i++]="WRAPPED_OPTIONS=$configstring";
        newenviron[i]=NULL;
        environ=newenviron;
 
 $envsave
        newenviron[i++]="HOME=$ENV{HOME}";
        newenviron[i++]="WRAPPED_OPTIONS=$configstring";
        newenviron[i]=NULL;
        environ=newenviron;
 

+       if (setregid(getegid(), -1) != 0 &&
+           setregid(getegid(), -1) != 0) {
+               perror("failed to drop real gid");
+               exit(1);
+       }
+       if (setreuid(geteuid(), -1) != 0 &&
+           setreuid(geteuid(), -1) != 0) {
+               perror("failed to drop real uid");
+               exit(1);
+       }
+

        execl("$this", "$this", NULL);
        execl("$this", "$this", NULL);

-       perror("failed to run $this");
+       perror("exec $this");

        exit(1);
 }
 EOF
        close OUT;
        exit(1);
 }
 EOF
        close OUT;

-       if (system("gcc", "$wrapper.c", "-o", $wrapper) != 0) {
-               error("failed to compile $wrapper.c");
+
+       my $cc=exists $ENV{CC} ? possibly_foolish_untaint($ENV{CC}) : 'cc';
+       if (system($cc, "$wrapper.c", "-o", "$wrapper.new") != 0) {
+               #translators: The parameter is a C filename.
+               error(sprintf(gettext("failed to compile %s"), "$wrapper.c"));

        }
        unlink("$wrapper.c");
        }
        unlink("$wrapper.c");

+       if (defined $config{wrappergroup}) {
+               my $gid=(getgrnam($config{wrappergroup}))[2];
+               if (! defined $gid) {
+                       error(sprintf("bad wrappergroup"));
+               }
+               if (! chown(-1, $gid, "$wrapper.new")) {
+                       error("chown $wrapper.new: $!");
+               }
+       }

        if (defined $config{wrappermode} &&
        if (defined $config{wrappermode} &&

-           ! chmod(oct($config{wrappermode}), $wrapper)) {
-               error("chmod $wrapper: $!");
+           ! chmod(oct($config{wrappermode}), "$wrapper.new")) {
+               error("chmod $wrapper.new: $!");
+       }
+       if (! rename("$wrapper.new", $wrapper)) {
+               error("rename $wrapper.new $wrapper: $!");

        }
        }

-       print "successfully generated $wrapper\n";
+       #translators: The parameter is a filename.
+       printf(gettext("successfully generated %s"), $wrapper);
+       print "\n";

 } #}}}
 
 1
 } #}}}
 
 1