fix logic error

[git.ikiwiki.info.git] / IkiWiki / Plugin / pagecount.pm

diff --git a/IkiWiki/Plugin/pagecount.pm b/IkiWiki/Plugin/pagecount.pm
index 80561350b5fe44d7d282fb5fac6b5c9ac8e295ea..8d36f057eb0820a62c9704988d66fde75ccf6c4b 100644 (file)
--- a/IkiWiki/Plugin/pagecount.pm
+++ b/IkiWiki/Plugin/pagecount.pm
@@ -20,20 +20,20 @@ sub getsetup () {
 
 sub preprocess (@) {
        my %params=@_;
 
 sub preprocess (@) {
        my %params=@_;

-       $params{pages}="*" unless defined $params{pages};
+       my $pages=defined $params{pages} ? $params{pages} : "*";

        
        

-       # Needs to update count whenever a page is added or removed, so
-       # register a presence dependency.
-       add_depends($params{page}, $params{pages}, presence => 1);
-       
-       my @pages;
-       if ($params{pages} eq "*") {
-               @pages=keys %pagesources;
-       }
-       else {
-               @pages=pagespec_match_list([keys %pagesources], $params{pages}, location => $params{page});
+       # Just get a list of all the pages, and count the items in it.
+       # Use a presence dependency to only update when pages are added
+       # or removed.
+
+       if ($pages eq '*') {
+               # optimisation to avoid needing to try matching every page
+               add_depends($params{page}, $pages, deptype("presence"));
+               return scalar keys %pagesources;

        }
        }

-       return $#pages+1;
+
+       return scalar pagespec_match_list($params{page}, $pages,
+               deptype => deptype("presence"));

 }
 
 1
 }
 
 1