conditional: use pagespec_match_list

[git.ikiwiki.info.git] / IkiWiki / Plugin / brokenlinks.pm

diff --git a/IkiWiki/Plugin/brokenlinks.pm b/IkiWiki/Plugin/brokenlinks.pm
index da97dbc2855bc59f17efe5792bacb6c36fe8e7f7..62a0a42f4547c865f000d02d2e188987951037ec 100644 (file)
--- a/IkiWiki/Plugin/brokenlinks.pm
+++ b/IkiWiki/Plugin/brokenlinks.pm
@@ -23,36 +23,30 @@ sub preprocess (@) {
        my %params=@_;
        $params{pages}="*" unless defined $params{pages};
        
-       # Needs to update whenever a page is added or removed, so
-       # register a dependency.
-       add_depends($params{page}, $params{pages});
+       # Needs to update whenever the links on a page change.
+       add_depends($params{page}, $params{pages}, deptype("links"));
        
-       my %broken;
-       foreach my $page (pagespec_match_list([keys %links],
-                       $params{pages}, location => $params{page})) {
-               my $discussion=gettext("discussion");
-               my %seen;
-               foreach my $link (@{$links{$page}}) {
-                       next if $seen{$link};
-                       $seen{$link}=1;
-                       next if $link =~ /.*\/\Q$discussion\E/i && $config{discussion};
-                       my $bestlink=bestlink($page, $link);
-                       next if length $bestlink;
-                       push @{$broken{$link}}, $page;
+       my @broken;
+       foreach my $link (keys %IkiWiki::brokenlinks) {
+               next if $link =~ /.*\/\Q$config{discussionpage}\E/i && $config{discussion};
+
+               my @pages;
+               foreach my $page (@{$IkiWiki::brokenlinks{$link}}) {
+                       push @pages, $page
+                               if pagespec_match($page, $params{pages}, location => $params{page});
                }
-       }
+               next unless @pages;
 
-       my @broken;
-       foreach my $link (keys %broken) {
-               my $page=$broken{$link}->[0];
+               my $page=$IkiWiki::brokenlinks{$link}->[0];
                push @broken, sprintf(gettext("%s from %s"),
                        htmllink($page, $params{destpage}, $link, noimageinline => 1),
                        join(", ", map {
                                htmllink($params{page}, $params{destpage}, $_,  noimageinline => 1)
-                       } @{$broken{$link}}));
+                       } @pages)
+               );
        }
        
-       return gettext("There are no broken links!") unless %broken;
+       return gettext("There are no broken links!") unless @broken;
        return "<ul>\n"
                .join("\n",
                        map {