minor refactor/optimisation

[git.ikiwiki.info.git] / IkiWiki / Plugin / template.pm

diff --git a/IkiWiki/Plugin/template.pm b/IkiWiki/Plugin/template.pm
index 5b4eeb3a8f66f609f42a6a2f13df0e138c00540f..3e024c5f81b11db1c7791fe8ef214d06f186cb09 100644 (file)
--- a/IkiWiki/Plugin/template.pm
+++ b/IkiWiki/Plugin/template.pm
@@ -4,49 +4,82 @@ package IkiWiki::Plugin::template;
 
 use warnings;
 use strict;
 
 use warnings;
 use strict;

-use IkiWiki;
+use IkiWiki 3.00;

 use HTML::Template;
 use Encode;
 
 use HTML::Template;
 use Encode;
 

-sub import { #{{{
-       IkiWiki::hook(type => "preprocess", id => "template", 
-               call => \&preprocess);
-} # }}}
+sub import {
+       hook(type => "getsetup", id => "template", call => \&getsetup);
+       hook(type => "preprocess", id => "template", call => \&preprocess,
+               scan => 1);
+}

 
 

-sub preprocess (@) { #{{{
+sub getsetup () {
+       return
+               plugin => {
+                       safe => 1,
+                       rebuild => undef,
+                       section => "widget",
+               },
+}
+
+sub preprocess (@) {

        my %params=@_;
 
        my %params=@_;
 

+       # This needs to run even in scan mode, in order to process
+       # links and other metadata included via the template.
+       my $scan=! defined wantarray;
+

        if (! exists $params{id}) {
        if (! exists $params{id}) {

-               return "[[template missing id parameter]]"
+               error gettext("missing id parameter")

        }
 
        my $template_page="templates/$params{id}";
        }
 
        my $template_page="templates/$params{id}";

-       IkiWiki::add_depends($params{page}, $template_page);
-
-       my $template_file=$IkiWiki::pagesources{$template_page};
-       return "[[template ".
-              IkiWiki::htmllink($params{page}, $params{destpage}, $template_page).
-              " not found]]"
-               unless defined $template_file;
-
-       my $template=HTML::Template->new(
-               filter => sub {
-                        my $text_ref = shift;
-                        $$text_ref=&Encode::decode_utf8($$text_ref);
-                },
-                filename => IkiWiki::srcfile($template_file),
-                die_on_bad_params => 0,
-               no_includes => 1,
-               blind_cache => 1,
-       );
+       add_depends($params{page}, $template_page);

 
 

-       foreach my $param (keys %params) {
-               $template->param($param => $params{$param});
+       my $template_file=$pagesources{$template_page};
+       return sprintf(gettext("template %s not found"),
+               htmllink($params{page}, $params{destpage}, "/".$template_page))
+                       unless defined $template_file;
+
+       my $template;
+       eval {
+               $template=HTML::Template->new(
+                       filter => sub {
+                               my $text_ref = shift;
+                               $$text_ref=&Encode::decode_utf8($$text_ref);
+                               chomp $$text_ref;
+                       },
+                       filename => srcfile($template_file),
+                               die_on_bad_params => 0,
+                       no_includes => 1,
+                       blind_cache => 1,
+               );
+       };
+       if ($@) {
+               error gettext("failed to process:")." $@"

        }
 
        }
 

+       $params{basename}=IkiWiki::basename($params{page});
+
+       foreach my $param (keys %params) {
+               my $value=IkiWiki::preprocess($params{page}, $params{destpage},
+                         IkiWiki::filter($params{page}, $params{destpagea},
+                         $params{$param}), $scan);
+               if ($template->query(name => $param)) {
+                       $template->param($param =>
+                               IkiWiki::htmlize($params{page}, $params{destpage},
+                                       pagetype($pagesources{$params{page}}),
+                                       $value));
+               }
+               if ($template->query(name => "raw_$param")) {
+                       $template->param("raw_$param" => $value);
+               }
+       }

 
        return IkiWiki::preprocess($params{page}, $params{destpage},
 
        return IkiWiki::preprocess($params{page}, $params{destpage},

-               $template->output);
-} # }}}
+              IkiWiki::filter($params{page}, $params{destpage},
+              $template->output), $scan);
+}

 
 1
 
 1