some notes about the security (or lack thereof) of plugins

[git.ikiwiki.info.git] / IkiWiki / Plugin / search.pm

diff --git a/IkiWiki/Plugin/search.pm b/IkiWiki/Plugin/search.pm
index 4ae9d7283f14779e2ea3271ade41fb96b2698a8d..a57a8404819b07f8449b634e0de32772a8c76ff8 100644 (file)
--- a/IkiWiki/Plugin/search.pm
+++ b/IkiWiki/Plugin/search.pm
@@ -7,6 +7,8 @@ use strict;
 use IkiWiki;
 
 sub import { #{{{
 use IkiWiki;
 
 sub import { #{{{

+       hook(type => "getopt", id => "hyperestraier",
+               call => \&getopt);

        hook(type => "checkconfig", id => "hyperestraier",
                call => \&checkconfig);
        hook(type => "pagetemplate", id => "hyperestraier",
        hook(type => "checkconfig", id => "hyperestraier",
                call => \&checkconfig);
        hook(type => "pagetemplate", id => "hyperestraier",


@@ -19,6 +21,12 @@ sub import { #{{{
                call => \&cgi);
 } # }}}
 
                call => \&cgi);
 } # }}}
 

+sub getopt () { #{{{
+        eval q{use Getopt::Long};
+        Getopt::Long::Configure('pass_through');
+        GetOptions("estseek=s" => \$config{estseek});
+} #}}}
+

 sub checkconfig () { #{{{
        foreach my $required (qw(url cgiurl)) {
                if (! length $config{$required}) {
 sub checkconfig () { #{{{
        foreach my $required (qw(url cgiurl)) {
                if (! length $config{$required}) {


@@ -55,7 +63,8 @@ sub change (@) { #{{{
        debug("updating hyperestraier search index");
        estcmd("gather -cm -bc -cl -sd",
                map {
        debug("updating hyperestraier search index");
        estcmd("gather -cm -bc -cl -sd",
                map {

-                       Encode::encode_utf8($config{destdir}."/".$renderedfiles{pagename($_)})
+                       Encode::encode_utf8($config{destdir}."/".$_)
+                               foreach @{$renderedfiles{pagename($_)}};

                } @_
        );
        estcfg();
                } @_
        );
        estcfg();


@@ -79,7 +88,7 @@ sub estcfg () { #{{{
        my $estdir="$config{wikistatedir}/hyperestraier";
        my $cgi=IkiWiki::basename($config{cgiurl});
        $cgi=~s/\..*$//;
        my $estdir="$config{wikistatedir}/hyperestraier";
        my $cgi=IkiWiki::basename($config{cgiurl});
        $cgi=~s/\..*$//;

-       open(TEMPLATE, ">$estdir/$cgi.tmpl") ||
+       open(TEMPLATE, ">:utf8", "$estdir/$cgi.tmpl") ||

                error("write $estdir/$cgi.tmpl: $!");
        print TEMPLATE IkiWiki::misctemplate("search", 
                "<!--ESTFORM-->\n\n<!--ESTRESULT-->\n\n<!--ESTINFO-->\n\n",
                error("write $estdir/$cgi.tmpl: $!");
        print TEMPLATE IkiWiki::misctemplate("search", 
                "<!--ESTFORM-->\n\n<!--ESTRESULT-->\n\n<!--ESTINFO-->\n\n",


@@ -99,8 +108,9 @@ sub estcfg () { #{{{
        close TEMPLATE;
        $cgi="$estdir/".IkiWiki::basename($config{cgiurl});
        unlink($cgi);
        close TEMPLATE;
        $cgi="$estdir/".IkiWiki::basename($config{cgiurl});
        unlink($cgi);

-       symlink("/usr/lib/estraier/estseek.cgi", $cgi) ||
-               error("symlink $cgi: $!");
+       my $estseek = defined $config{estseek} ? $config{estseek} : '/usr/lib/estraier/estseek.cgi';
+       symlink($estseek, $cgi) ||
+               error("symlink $estseek $cgi: $!");

 } # }}}
 
 sub estcmd ($;@) { #{{{
 } # }}}
 
 sub estcmd ($;@) { #{{{