oops

[git.ikiwiki.info.git] / doc / todo / need_global_renamepage_hook.mdwn

diff --git a/doc/todo/need_global_renamepage_hook.mdwn b/doc/todo/need_global_renamepage_hook.mdwn
index 9c987aac4101c047bfa1ea5fea68412f692c3f41..e3cec4a9b1597f3de58347418ae092cacf8ffa1d 100644 (file)
--- a/doc/todo/need_global_renamepage_hook.mdwn
+++ b/doc/todo/need_global_renamepage_hook.mdwn
@@ -61,7 +61,7 @@ would solve my problem. Hmmm? --[[intrigeri]]
 >>> not be broken. I will thus keep the existing `renamepage` as it
 >>> is, and call `rename` the global hook I need. --[[intrigeri]]
 
 >>> not be broken. I will thus keep the existing `renamepage` as it
 >>> is, and call `rename` the global hook I need. --[[intrigeri]]
 

->>>> Done in my `po` branch. --[[intrigeri]]
+>>>> [[Done]] in my `po` branch. --[[intrigeri]]

 
 I think I see a problem in the rename hook. The hook is called
 before the plugin adds any subpages to the set of pages to rename.
 
 I think I see a problem in the rename hook. The hook is called
 before the plugin adds any subpages to the set of pages to rename.


@@ -103,3 +103,13 @@ hashes is desired, it could return the full set of hashes.
 >> plugins use the hook; plugin A would see when plugin B adds a new file
 >> to be renamed. And the subpage renaming stuff could probably be moved
 >> into the rename hook too. --[[Joey]] 
 >> plugins use the hook; plugin A would see when plugin B adds a new file
 >> to be renamed. And the subpage renaming stuff could probably be moved
 >> into the rename hook too. --[[Joey]] 

+>>>
+>>> I've implemented this nice solution in my po branch, please review.
+>>> I'm slowly coming back to do the last bits needed to get my po and
+>>> meta branch merged.  --[[intrigeri]]
+
+>>>> It looks good. I made some small changes to it in my own po branch.
+>>>> Nothing significant really. If this were not tied up in the po branch,
+>>>> I've have merged it to master already. --[[Joey]] 
+
+>>>> Thanks, this is great :) --[[intrigeri]]