update info on my split-view setup, and ask for plugin advice

[git.ikiwiki.info.git] / IkiWiki / Receive.pm

diff --git a/IkiWiki/Receive.pm b/IkiWiki/Receive.pm
index 88fb4972571e7013480f943483a73a11e5b9a93d..5908e09f953ad09cb576cae6c956230be497d6df 100644 (file)
--- a/IkiWiki/Receive.pm
+++ b/IkiWiki/Receive.pm
@@ -35,10 +35,17 @@ EOF
                        }
                        "u != $uid";
                } @{$config{untrusted_committers}}).
-               ") exit(0);\n";
+               ") {\n";
 
        
        $ret.=<<"EOF";
+                       /* Trusted user.
+                        * Consume all stdin before exiting, as git may
+                        * otherwise be unhappy. */
+                       char buf[256];
+                       while (read(0, &buf, 256) != 0) {}
+                       exit(0);
+               }
                asprintf(&s, "CALLER_UID=%i", u);
                newenviron[i++]=s;
        }
@@ -73,73 +80,12 @@ sub test () {
                }) || error("failed adding user");
        }
 
-       test_changes(cgi => $cgi,
+       IkiWiki::check_canchange(
+               cgi => $cgi,
                session => $session,
                changes => [IkiWiki::rcs_receive()]
        );
        exit 0;
 }
 
-sub test_changes {
-       my %params = @_;
-       my $cgi = $params{cgi};
-       my $session = $params{session};
-       my @changes = @{$params{changes}};
-
-       my %newfiles;
-       foreach my $change (@changes) {
-               # This untaint is safe because we check file_pruned and
-               # wiki_file_regexp.
-               my ($file)=$change->{file}=~/$config{wiki_file_regexp}/;
-               $file=IkiWiki::possibly_foolish_untaint($file);
-               if (! defined $file || ! length $file ||
-                   IkiWiki::file_pruned($file)) {
-                       error(gettext("bad file name %s"), $file);
-               }
-
-               my $type=pagetype($file);
-               my $page=pagename($file) if defined $type;
-
-               if ($change->{action} eq 'add') {
-                       $newfiles{$file}=1;
-               }
-
-               if ($change->{action} eq 'change' ||
-                   $change->{action} eq 'add') {
-                       if (defined $page) {
-                               IkiWiki::check_canedit($page, $cgi, $session);
-                               next;
-                       }
-                       else {
-                               if (IkiWiki::Plugin::attachment->can("check_canattach")) {
-                                       IkiWiki::Plugin::attachment::check_canattach($session, $file, $change->{path});
-                                       IkiWiki::check_canedit($file, $cgi, $session);
-                                       next;
-                               }
-                       }
-               }
-               elsif ($change->{action} eq 'remove') {
-                       # check_canremove tests to see if the file is present
-                       # on disk. This will fail when a single commit adds a
-                       # file and then removes it again. Avoid the problem
-                       # by not testing the removal in such pairs of changes.
-                       # (The add is still tested, just to make sure that
-                       # no data is added to the repo that a web edit
-                       # could not add.)
-                       next if $newfiles{$file};
-
-                       if (IkiWiki::Plugin::remove->can("check_canremove")) {
-                               IkiWiki::Plugin::remove::check_canremove(defined $page ? $page : $file, $cgi, $session);
-                               IkiWiki::check_canedit(defined $page ? $page : $file, $cgi, $session);
-                               next;
-                       }
-               }
-               else {
-                       error "unknown action ".$change->{action};
-               }
-
-               error sprintf(gettext("you are not allowed to change %s"), $file);
-       }
-}
-
 1