Merge remote branch 'smcv/ready/sslcookie-auto'

[git.ikiwiki.info.git] / IkiWiki / CGI.pm

diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index 04f24b04f986c2618b0cbf619e09ba7dfbff58ee..ede194ff9aee945dc0fb471bedaa47bf93eda829 100644 (file)
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -12,16 +12,17 @@ use Encode;
 sub printheader ($) {
        my $session=shift;
        
 sub printheader ($) {
        my $session=shift;
        

-       if ($config{sslcookie}) {
+       if ($ENV{HTTPS} || $config{sslcookie}) {

                print $session->header(-charset => 'utf-8',
                        -cookie => $session->cookie(-httponly => 1, -secure => 1));
                print $session->header(-charset => 'utf-8',
                        -cookie => $session->cookie(-httponly => 1, -secure => 1));

-       } else {
+       }
+       else {

                print $session->header(-charset => 'utf-8',
                        -cookie => $session->cookie(-httponly => 1));
        }
 }
 
                print $session->header(-charset => 'utf-8',
                        -cookie => $session->cookie(-httponly => 1));
        }
 }
 

-sub showform ($$$$;@) {
+sub prepform {

        my $form=shift;
        my $buttons=shift;
        my $session=shift;
        my $form=shift;
        my $buttons=shift;
        my $session=shift;


@@ -34,13 +35,24 @@ sub showform ($$$$;@) {
                });
        }
 
                });
        }
 

+       return $form;
+}
+
+sub showform ($$$$;@) {
+       my $form=prepform(@_);
+       shift;
+       my $buttons=shift;
+       my $session=shift;
+       my $cgi=shift;
+

        printheader($session);
        print misctemplate($form->title, $form->render(submit => $buttons), @_);
 }
 
 sub redirect ($$) {
        my $q=shift;
        printheader($session);
        print misctemplate($form->title, $form->render(submit => $buttons), @_);
 }
 
 sub redirect ($$) {
        my $q=shift;

-       my $url=shift;
+       eval q{use URI};
+       my $url=URI->new(shift);

        if (! $config{w3mmode}) {
                print $q->redirect($url);
        }
        if (! $config{w3mmode}) {
                print $q->redirect($url);
        }


@@ -51,7 +63,7 @@ sub redirect ($$) {
 }
 
 sub decode_cgi_utf8 ($) {
 }
 
 sub decode_cgi_utf8 ($) {

-       # decode_form_utf8 method is needed for 5.10
+       # decode_form_utf8 method is needed for 5.01

        if ($] < 5.01) {
                my $cgi = shift;
                foreach my $f ($cgi->param) {
        if ($] < 5.01) {
                my $cgi = shift;
                foreach my $f ($cgi->param) {


@@ -64,8 +76,9 @@ sub decode_form_utf8 ($) {
        if ($] >= 5.01) {
                my $form = shift;
                foreach my $f ($form->field) {
        if ($] >= 5.01) {
                my $form = shift;
                foreach my $f ($form->field) {

+                       my @value=map { decode_utf8($_) } $form->field($f);

                        $form->field(name  => $f,
                        $form->field(name  => $f,

-                                    value => decode_utf8($form->field($f)),
+                                    value => \@value,

                                     force => 1,
                        );
                }
                                     force => 1,
                        );
                }


@@ -87,9 +100,10 @@ sub needsignin ($$) {
        }
 }
 
        }
 }
 

-sub cgi_signin ($$) {
+sub cgi_signin ($$;$) {

        my $q=shift;
        my $session=shift;
        my $q=shift;
        my $session=shift;

+       my $returnhtml=shift;

 
        decode_cgi_utf8($q);
        eval q{use CGI::FormBuilder};
 
        decode_cgi_utf8($q);
        eval q{use CGI::FormBuilder};


@@ -102,16 +116,13 @@ sub cgi_signin ($$) {
                required => 'NONE',
                javascript => 0,
                params => $q,
                required => 'NONE',
                javascript => 0,
                params => $q,

-               action => $config{cgiurl},
+               action => cgiurl(),

                header => 0,
                template => {type => 'div'},
                header => 0,
                template => {type => 'div'},

-               stylesheet => baseurl()."style.css",
+               stylesheet => 1,

        );
        my $buttons=["Login"];
        
        );
        my $buttons=["Login"];
        

-       if ($q->param("do") ne "signin" && !$form->submitted) {
-               $form->text(gettext("You need to log in first."));
-       }

        $form->field(name => "do", type => "hidden", value => "signin",
                force => 1);
        
        $form->field(name => "do", type => "hidden", value => "signin",
                force => 1);
        


@@ -126,6 +137,11 @@ sub cgi_signin ($$) {
                $form->validate;
        }
 
                $form->validate;
        }
 

+       if ($returnhtml) {
+               $form=prepform($form, $buttons, $session, $q);
+               return $form->render(submit => $buttons);
+       }
+

        showform($form, $buttons, $session, $q);
 }
 
        showform($form, $buttons, $session, $q);
 }
 


@@ -143,7 +159,7 @@ sub cgi_postsignin ($$) {
        }
        else {
                if ($config{sslcookie} && ! $q->https()) {
        }
        else {
                if ($config{sslcookie} && ! $q->https()) {

-                       error(gettext("probable misconfiguration: sslcookie is set, but you are attepting to login via http, not https"));
+                       error(gettext("probable misconfiguration: sslcookie is set, but you are attempting to login via http, not https"));

                }
                else {
                        error(gettext("login failed, perhaps you need to turn on cookies?"));
                }
                else {
                        error(gettext("login failed, perhaps you need to turn on cookies?"));


@@ -182,9 +198,9 @@ sub cgi_prefs ($$) {
                required => 'NONE',
                javascript => 0,
                params => $q,
                required => 'NONE',
                javascript => 0,
                params => $q,

-               action => $config{cgiurl},
+               action => cgiurl(),

                template => {type => 'div'},
                template => {type => 'div'},

-               stylesheet => baseurl()."style.css",
+               stylesheet => 1,

                fieldsets => [
                        [login => gettext("Login")],
                        [preferences => gettext("Preferences")],
                fieldsets => [
                        [login => gettext("Login")],
                        [preferences => gettext("Preferences")],


@@ -215,11 +231,11 @@ sub cgi_prefs ($$) {
        
        if ($form->submitted eq 'Logout') {
                $session->delete();
        
        if ($form->submitted eq 'Logout') {
                $session->delete();

-               redirect($q, $config{url});
+               redirect($q, baseurl(undef));

                return;
        }
        elsif ($form->submitted eq 'Cancel') {
                return;
        }
        elsif ($form->submitted eq 'Cancel') {

-               redirect($q, $config{url});
+               redirect($q, baseurl(undef));

                return;
        }
        elsif ($form->submitted eq 'Save Preferences' && $form->validate) {
                return;
        }
        elsif ($form->submitted eq 'Save Preferences' && $form->validate) {


@@ -231,14 +247,20 @@ sub cgi_prefs ($$) {
                $form->text(gettext("Preferences saved."));
        }
        
                $form->text(gettext("Preferences saved."));
        }
        

-       showform($form, $buttons, $session, $q);
+       showform($form, $buttons, $session, $q,
+               prefsurl => "", # avoid showing the preferences link
+       );

 }
 
 }
 

-sub cgi_custom_failure ($$) {
-       my $header=shift;
+sub cgi_custom_failure ($$$) {
+       my $q=shift;
+       my $httpstatus=shift;

        my $message=shift;
 
        my $message=shift;
 

-       print $header;
+       print $q->header(
+               -status => $httpstatus,
+               -charset => 'utf-8',
+       );

        print $message;
 
        # Internet Explod^Hrer won't show custom 404 responses
        print $message;
 
        # Internet Explod^Hrer won't show custom 404 responses


@@ -252,16 +274,30 @@ sub check_banned ($$) {
        my $q=shift;
        my $session=shift;
 
        my $q=shift;
        my $session=shift;
 

+       my $banned=0;

        my $name=$session->param("name");
        my $name=$session->param("name");

-       if (defined $name) {
-               if (grep { $name eq $_ } @{$config{banned_users}}) {
-                       $session->delete();
-                       cgi_savesession($session);
-                       cgi_custom_failure(
-                               $q->header(-status => "403 Forbidden"),
-                               gettext("You are banned."));
+       if (defined $name && 
+           grep { $name eq $_ } @{$config{banned_users}}) {
+               $banned=1;
+       }
+
+       foreach my $b (@{$config{banned_users}}) {
+               if (pagespec_match("", $b,
+                       ip => $session->remote_addr(),
+                       name => defined $name ? $name : "",
+               )) {
+                       $banned=1;
+                       last;

                }
        }
                }
        }

+
+       if ($banned) {
+               $session->delete();
+               cgi_savesession($session);
+               cgi_custom_failure(
+                       $q, "403 Forbidden",
+                       gettext("You are banned."));
+       }

 }
 
 sub cgi_getsession ($) {
 }
 
 sub cgi_getsession ($) {