add a ' ' to prevent autosmiley eating a )

[git.ikiwiki.info.git] / IkiWiki / CGI.pm

diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index 3fadc462e5704cf446dc9e347d710265b1eae374..04f24b04f986c2618b0cbf619e09ba7dfbff58ee 100644 (file)
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -142,7 +142,12 @@ sub cgi_postsignin ($$) {
                exit;
        }
        else {
                exit;
        }
        else {

-               error(gettext("login failed, perhaps you need to turn on cookies?"));
+               if ($config{sslcookie} && ! $q->https()) {
+                       error(gettext("probable misconfiguration: sslcookie is set, but you are attepting to login via http, not https"));
+               }
+               else {
+                       error(gettext("login failed, perhaps you need to turn on cookies?"));
+               }

        }
 }
 
        }
 }
 


@@ -229,6 +234,20 @@ sub cgi_prefs ($$) {
        showform($form, $buttons, $session, $q);
 }
 
        showform($form, $buttons, $session, $q);
 }
 

+sub cgi_custom_failure ($$) {
+       my $header=shift;
+       my $message=shift;
+
+       print $header;
+       print $message;
+
+       # Internet Explod^Hrer won't show custom 404 responses
+       # unless they're >= 512 bytes
+       print ' ' x 512;
+
+       exit;
+}
+

 sub check_banned ($$) {
        my $q=shift;
        my $session=shift;
 sub check_banned ($$) {
        my $q=shift;
        my $session=shift;


@@ -236,11 +255,11 @@ sub check_banned ($$) {
        my $name=$session->param("name");
        if (defined $name) {
                if (grep { $name eq $_ } @{$config{banned_users}}) {
        my $name=$session->param("name");
        if (defined $name) {
                if (grep { $name eq $_ } @{$config{banned_users}}) {

-                       print $q->header(-status => "403 Forbidden");

                        $session->delete();
                        $session->delete();

-                       print gettext("You are banned.");

                        cgi_savesession($session);
                        cgi_savesession($session);

-                       exit;
+                       cgi_custom_failure(
+                               $q->header(-status => "403 Forbidden"),
+                               gettext("You are banned."));

                }
        }
 }
                }
        }
 }


@@ -317,7 +336,7 @@ sub cgi (;$$) {
                        error("\"do\" parameter missing");
                }
        }
                        error("\"do\" parameter missing");
                }
        }

-       
+

        # Need to lock the wiki before getting a session.
        lockwiki();
        loadindex();
        # Need to lock the wiki before getting a session.
        lockwiki();
        loadindex();