rename plugins/osm/Tincho.mdwn to users/Tincho.mdwn

[git.ikiwiki.info.git] / doc / plugins / osm / discussion.mdwn

diff --git a/doc/plugins/osm/discussion.mdwn b/doc/plugins/osm/discussion.mdwn
index 2a41b35d205e161470072db64f13e676d0c4be71..05c2294c3961613ef23095b2d083254813af4498 100644 (file)
--- a/doc/plugins/osm/discussion.mdwn
+++ b/doc/plugins/osm/discussion.mdwn
@@ -45,9 +45,11 @@ For usability it would be great if it was possible to display the active waypoin
 
 - Maps actually work again
 - Maps work when embedded in HTTPS sites
 
 - Maps actually work again
 - Maps work when embedded in HTTPS sites

-- Multiple maps and multiple waypoints in a page probably work better now
+- Multiple maps and multiple waypoints in a page work properly

 - Maps _do_ appear in inlines
 - Pagestate hash gets cleaned up better after edit/preview/delete
 - Maps _do_ appear in inlines
 - Pagestate hash gets cleaned up better after edit/preview/delete

+- Unigue icon for "active waypoint" works, also possible to select manually any waypoint to highlight
+- Good test coverage, including inlines and multiple maps/waypoints per page

 
 ### Wishlist
 
 
 ### Wishlist
 


@@ -62,7 +64,12 @@ For usability it would be great if it was possible to display the active waypoin
 - Given this is backward-incompatible, dhould we call it something other than "osm"?
 - What needs scrubbing? Have we covered all the bases? Too many bases?
 - Should we vendor Leaflet into an underlay, instead of needing a URL to load it from a CDN? [[schmonz]] somewhat prefers this, so we avoid needing external resources by default, avoid breaking when the Leaflet CDN is down, etc.
 - Given this is backward-incompatible, dhould we call it something other than "osm"?
 - What needs scrubbing? Have we covered all the bases? Too many bases?
 - Should we vendor Leaflet into an underlay, instead of needing a URL to load it from a CDN? [[schmonz]] somewhat prefers this, so we avoid needing external resources by default, avoid breaking when the Leaflet CDN is down, etc.

-- Should we write some tests before merging? `osm.pm` hadn't had any, FWIW
+- Should we write some tests before merging? `osm.pm` hadn't had any, FWIW -- [[Tincho]] Done
+
+Bump! Tincho would like to see us merge his effort, and FWIW I'd also
+rather not have to carry around a local copy of his work to get a map
+with waypoints on my HTTPS site. [[smcv]], can you spare some round
+tuits to give us your thoughts? --[[schmonz]]

 
 ----
 
 
 ----
 


@@ -75,3 +82,5 @@ Looks like good changes to me!
 > did a grep `Placemark pois.kml|wc -l` which returned 3468. Which perhaps isn't that much? I'm thinking about how individual poi files might affect performance. My performance troubles are more likely to be with my tweaked album and img plugins though.
 
 --[[kjs]]
 > did a grep `Placemark pois.kml|wc -l` which returned 3468. Which perhaps isn't that much? I'm thinking about how individual poi files might affect performance. My performance troubles are more likely to be with my tweaked album and img plugins though.
 
 --[[kjs]]

+
+> The issue about not getting all the waipoints until you rebuild has been solved, the current plugin had issues with keeping track of updated and deleted waypoints which is now fixed in my branch. --[[Tincho]]