move dedup code into function, simplify

[git.ikiwiki.info.git] / IkiWiki / Plugin / brokenlinks.pm

diff --git a/IkiWiki/Plugin/brokenlinks.pm b/IkiWiki/Plugin/brokenlinks.pm
index 09ce181cff2a11f6e568e875baf95522cd211366..bf0d7560dbc8a86a28b1ad694d9de326d0153f1f 100644 (file)
--- a/IkiWiki/Plugin/brokenlinks.pm
+++ b/IkiWiki/Plugin/brokenlinks.pm
@@ -4,39 +4,63 @@ package IkiWiki::Plugin::brokenlinks;
 
 use warnings;
 use strict;
-use IkiWiki;
+use IkiWiki 3.00;
 
-sub import { #{{{
-       IkiWiki::hook(type => "preprocess", id => "brokenlinks",
-               call => \&preprocess);
-} # }}}
+sub import {
+       hook(type => "getsetup", id => "brokenlinks", call => \&getsetup);
+       hook(type => "preprocess", id => "brokenlinks", call => \&preprocess);
+}
 
-sub preprocess (@) { #{{{
+sub getsetup {
+       return
+               plugin => {
+                       safe => 1,
+                       rebuild => undef,
+               },
+}
+
+sub preprocess (@) {
        my %params=@_;
        $params{pages}="*" unless defined $params{pages};
        
        # Needs to update whenever a page is added or removed, so
        # register a dependency.
-       IkiWiki::add_depends($params{page}, $params{pages});
+       add_depends($params{page}, $params{pages});
        
-       my @broken;
-       foreach my $page (keys %IkiWiki::links) {
-               if (IkiWiki::globlist_match($page, $params{pages})) {
-                       foreach my $link (@{$IkiWiki::links{$page}}) {
-                               next if $link =~ /.*\/discussion/i && $IkiWiki::config{discussion};
-                               my $bestlink=IkiWiki::bestlink($page, $link);
+       my %broken;
+       foreach my $page (keys %links) {
+               if (pagespec_match($page, $params{pages}, location => $params{page})) {
+                       my $discussion=gettext("discussion");
+                       my %seen;
+                       foreach my $link (@{$links{$page}}) {
+                               next if $seen{$link};
+                               $seen{$link}=1;
+                               next if $link =~ /.*\/\Q$discussion\E/i && $config{discussion};
+                               my $bestlink=bestlink($page, $link);
                                next if length $bestlink;
-                               push @broken,
-                                       IkiWiki::htmllink($page, $params{destpage}, $link, 1).
-                                       " in ".
-                                       IkiWiki::htmllink($params{page}, $params{destpage}, $page, 1);
+                               push @{$broken{$link}}, $page;
                        }
                }
        }
+
+       my @broken;
+       foreach my $link (keys %broken) {
+               my $page=$broken{$link}->[0];
+               push @broken, sprintf(gettext("%s from %s"),
+                       htmllink($page, $params{destpage}, $link, noimageinline => 1),
+                       join(", ", map {
+                               htmllink($params{page}, $params{destpage}, $_,  noimageinline => 1)
+                       } @{$broken{$link}}));
+       }
        
-       return "There are no broken links!" unless @broken;
-       my %seen;
-       return "<ul>\n".join("\n", map { "<li>$_</li>" } grep { ! $seen{$_}++ } sort @broken)."</ul>\n";
-} # }}}
+       return gettext("There are no broken links!") unless %broken;
+       return "<ul>\n"
+               .join("\n",
+                       map {
+                               "<li>$_</li>"
+                       }
+                       sort @broken)
+               ."</ul>\n";
+}
 
 1