patchmeister

[git.ikiwiki.info.git] / doc / bugs / ikiwiki_ignores_PATH_environment.mdwn

diff --git a/doc/bugs/ikiwiki_ignores_PATH_environment.mdwn b/doc/bugs/ikiwiki_ignores_PATH_environment.mdwn
index 5097acaef5c2de5fe74208ee8436f59f2a282351..6781d4b4bc7617ace66dedf26c871f7200d69bec 100644 (file)
--- a/doc/bugs/ikiwiki_ignores_PATH_environment.mdwn
+++ b/doc/bugs/ikiwiki_ignores_PATH_environment.mdwn
@@ -16,3 +16,9 @@ This makes it a little hard to specify which specific binaries should be used, e
 > The ikiwiki script's own sanitization of PATH was done to make perl taint
 > checking happy, but as taint checking is disabled anyway, I have removed
 > that. [[done]] --[[Joey]] 
 > The ikiwiki script's own sanitization of PATH was done to make perl taint
 > checking happy, but as taint checking is disabled anyway, I have removed
 > that. [[done]] --[[Joey]] 

+
+Question: Do ikiwiki.cgi and the RCS post-commit script sanitize the $PATH separately from bin/ikiwiki?  If not, then bin/ikiwiki is probably right to sanitize the $PATH; otherwise you've created a security hole with access to the account that ikiwiki is SUID to. It'd be nice if /opt/local/bin were earlier in the $PATH, but that can be changed (as noted) in the setup file. [[Glenn|geychaner@mac.com]] (Also the person who started this by filing an issue with MacPorts; I'm experimenting with ikiwiki for collaborative documentation.)
+
+> The suid wrappers remove all environment variables except for a few used
+> for CGI. PATH is not propigated by them, so when they run ikiwiki it will
+> get the system's default path now. --[[Joey]]