Exclude working directory from library path (CVE-2016-1238)

[git.ikiwiki.info.git] / doc / todo / pagedown_plugin / discussion.mdwn

diff --git a/doc/todo/pagedown_plugin/discussion.mdwn b/doc/todo/pagedown_plugin/discussion.mdwn
index 165b3d776409358fd8c5f21f2134dfe5f322f194..42015c4ff2c3dfb5e508de13a5e2ed64a3fed888 100644 (file)
--- a/doc/todo/pagedown_plugin/discussion.mdwn
+++ b/doc/todo/pagedown_plugin/discussion.mdwn
@@ -100,12 +100,47 @@ Given all the above, what about upgrading this plugin to use pagedown instead of
 >> (which alleviates all possible copyright problems). You can take test the 
 >> plugin at <http://testwiki.anarc.at/>
 >> 
 >> (which alleviates all possible copyright problems). You can take test the 
 >> plugin at <http://testwiki.anarc.at/>
 >> 

->> There are only two issues I could find during testing:
+>> There are only three issues I could find during testing:

 >> 
 >>  1. two previews are showed (the showdown one and the regular ikiwiki one),
 >>     which can be confusing, but is still necessary because the showdown one 
 >>     doesn't parse ikiwiki directives. 
 >> 
 >>  1. two previews are showed (the showdown one and the regular ikiwiki one),
 >>     which can be confusing, but is still necessary because the showdown one 
 >>     doesn't parse ikiwiki directives. 

->>  2. the wiki needs to be rebuilt when the plugin is activated, which is not
->>     done by default
+>>  2. the wiki needs to be rebuilt when the plugin is first activated for the
+>>     stylesheets to regenerate. new wikis are not affected, and this can be
+>>     deployed massively on farms without user intervention.
+>>  3. on large pages, the edit screen isn't in the first screen, so it's not 
+>>     obvious we're editing the page, which is also a little confusing - we 
+>>     would need an anchor in there... Update: a simple patch fixes that... 
+>>     but in a rather crude way:

 >>
 >>

->> So let's work on merging that pretty branch already shall we? :) --[[anarcat]]
+>>  [[!format diff """
+--- a/IkiWiki/Render.pm
++++ b/IkiWiki/Render.pm
+@@ -87,7 +87,7 @@ sub genpage ($$) {
+        my $actions=0;
+        if (length $config{cgiurl}) {
+                if (IkiWiki->can("cgi_editpage")) {
+-                       $template->param(editurl => cgiurl(do => "edit", page => $page));
++                       $template->param(editurl => cgiurl(do => "edit", page => $page) . '#editcontent');
+                        $actions++;
+                }
+        }
+"""]]
+>>      ideally, we would show the edit box next to the page preview... And there's a way to do that too! But it requires some more CSS hackery, like [this](http://css-tricks.com/scrollfollow-sidebar/), for example:
+>>
+>>     #wmd-preview {
+>>       position: relative;
+>>       margin: 15px auto;
+>>       float: left;
+>>       width: 50%;
+>>     }
+>>     form {
+>>       position: fixed;
+>>       margin-left: 50%;
+>>     }
+>>
+>> But this is getting a little crazy and I need to sleep now.
+>>
+>> [[!template id=gitbranch branch=anarcat/pagedown author="[[anarcat]]"]]
+>>
+>> Anyways, let's work on merging that pretty branch already shall we? :) --[[anarcat]]