belated note about upgrades to 2.5

[git.ikiwiki.info.git] / doc / bugs / Problems_with_graphviz.pm_plug-in.mdwn

diff --git a/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn b/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn
index 0c679a9103ce603bd67f6dd80e33142b4c7af026..1ec3e32bceb5f2cd064ff25e5d4553878b221759 100644 (file)
--- a/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn
+++ b/doc/bugs/Problems_with_graphviz.pm_plug-in.mdwn
@@ -3,7 +3,7 @@ The graphviz.pm plug-in currently attempts to read PNG data in UTF-8 mode, which
     utf8 "\x89" does not map to Unicode at /usr/local/lib/perl5/site_perl/5.8.8/IkiWiki/Plugin/graphviz.pm line 53, <IN> chunk 1.
     Wide character in subroutine entry at /usr/local/lib/perl5/site_perl/5.8.8/IkiWiki/Plugin/graphviz.pm line 68.
 
-> Ok, will remove the binmode IN then. [[done]] --[[Joey]]
+> Ok, will remove the binmode IN then. done --[[Joey]]
 
 >> Thanks --[[HenrikBrixAndersen]]
 
@@ -16,7 +16,12 @@ It also generates image URLs relative to the page being rendered, which means th
 >> I have just tested ikiwiki-2.5. The code in question still looks
 >> the same, and the patch is still needed for making the graphviz
 >> plug-in work in preview mode here.
->>
+
+>>> No, the relevant code is just above the bit you patched. Notice that in
+>>> preview mode, it returns an img tag with the graphviz drawing embedded
+>>> in it, using base64 encoding. Unless you can show me why that doesn't
+>>> work, I still think this bug is done. --[[Joey]]
+
 >> Here is an updated patch againt ikiwiki-2.5: