- $params{content} =~ s{(?:^|(?<=\s))(\\?)$smiley_regexp(?:(?=\s)|$)}{
- $1 ? $2 : htmllink($params{page}, $params{page}, $smileys{$2}, 0, 0, $2)
- }egs;
+ $_=$params{content};
+ return $_ unless length $smiley_regexp;
+
+MATCH: while (m{(?:^|(?<=\s|>))(\\?)$smiley_regexp(?:(?=\s|<)|$)}g) {
+ my $escape=$1;
+ my $smiley=$2;
+ my $epos=$-[1];
+ my $spos=$-[2];
+
+ # Smilies are not allowed inside <pre> or <code>.
+ # For each tag in turn, match forward to find the next <tag>
+ # or </tag> after the smiley.
+ my $pos=pos;
+ foreach my $tag ("pre", "code") {
+ if (m/<(\/)?\s*$tag\s*>/isg && defined $1) {
+ # </tag> found first, so the smiley is
+ # inside the tag, so do not expand it.
+ next MATCH;
+ }
+ # Reset pos back to where it was before this test.
+ pos=$pos;
+ }
+
+ if ($escape) {
+ # Remove escape.
+ substr($_, $epos, 1)="";
+ pos=$epos+1;
+ }
+ else {
+ # Replace the smiley with its expanded value.
+ substr($_, $spos, length($smiley))=
+ htmllink($params{page}, $params{destpage},
+ $smileys{$smiley}, linktext => $smiley);
+ pos=$epos+1;
+ }
+
+ # Breaks out at end, otherwise it will scan through again,
+ # replacing de-escaped ones.
+ #last unless defined pos;
+ }