po plugin: bugfix (calling function in wrong module)

[git.ikiwiki.info.git] / IkiWiki / Setup / Standard.pm

diff --git a/IkiWiki/Setup/Standard.pm b/IkiWiki/Setup/Standard.pm
index 99da7ed86da91a7c83f7a612113b94a9bccbb1e0..92f887f0c4c1b565f1949b963e40da94e88c08be 100644 (file)
--- a/IkiWiki/Setup/Standard.pm
+++ b/IkiWiki/Setup/Standard.pm
@@ -10,7 +10,7 @@ use strict;
 use IkiWiki;
 
 sub import { #{{{
-       $IkiWiki::Setup::raw_setup=$_[1];
+       IkiWiki::Setup::merge($_[1]);
 } #}}}
 
 sub dumpline ($$$$) { #{{{
@@ -28,14 +28,13 @@ sub dumpline ($$$$) { #{{{
        local $Data::Dumper::Quotekeys=0;
        
        my $dumpedvalue;
-       if ($type eq 'boolean' || $type eq 'integer') {
+       if (($type eq 'boolean' || $type eq 'integer') && $value=~/^[0-9]+$/) {
                # avoid quotes
                $dumpedvalue=$value;
        }
-       elsif ($type eq 'string' && ref $value eq 'ARRAY' && @$value &&
-           ! grep { /[^-A-Za-z0-9_]/ } @$value) {
+       elsif (ref $value eq 'ARRAY' && @$value && ! grep { /[^\S]/ } @$value) {
                # dump simple array as qw{}
-               $dumpedvalue="[qw{ ".join(" ", @$value)." }]";
+               $dumpedvalue="[qw{".join(" ", @$value)."}]";
        }
        else {
                $dumpedvalue=Dumper($value);
@@ -63,7 +62,7 @@ sub dumpvalues ($@) { #{{{
                my $key=shift;
                my %info=%{shift()};
 
-               next if $info{type} eq "internal";
+               next if $key eq "plugin" || $info{type} eq "internal";
                
                push @ret, "\t# ".$info{description} if exists $info{description};
                
@@ -74,6 +73,9 @@ sub dumpvalues ($@) { #{{{
                elsif (exists $info{example}) {
                        push @ret, dumpline($key, $info{example}, $info{type}, "#");
                }
+               else {
+                       push @ret, dumpline($key, "", $info{type}, "#");
+               }
        }
        return @ret;
 } #}}}
@@ -84,33 +86,18 @@ sub gendump ($) { #{{{
        my @ret;
        
        # disable logging to syslog while dumping
-       $config{syslog}=0;
+       $config{syslog}=undef;
 
-       push @ret, "\t# basic setup";
        push @ret, dumpvalues(\%setup, IkiWiki::getsetup());
-
-       # Load all plugins, so that all setup options are available.
-       # (But skip a few problematic external demo plugins.)
-       my @plugins=grep { ! /^(externaldemo|pythondemo|\Q$config{rcs}\E)$/ }
-               sort(IkiWiki::listplugins());
-       unshift @plugins, $config{rcs} if $config{rcs}; # rcs plugin 1st
-       foreach my $plugin (@plugins) {
-               eval { IkiWiki::loadplugin($plugin) };
-               if (exists $IkiWiki::hooks{checkconfig}{$plugin}{call}) {
-                       my @s=eval { $IkiWiki::hooks{checkconfig}{$plugin}{call}->() };
+       foreach my $pair (IkiWiki::Setup::getsetup()) {
+               my $plugin=$pair->[0];
+               my $setup=$pair->[1];
+               my @values=dumpvalues(\%setup, @{$setup});
+               if (@values) {
+                       push @ret, "", "\t# $plugin plugin", @values;
                }
        }
 
-       foreach my $id (@plugins) {
-               if (exists $IkiWiki::hooks{getsetup}{$id}{call}) {
-                       # use an array rather than a hash, to preserve order
-                       my @s=eval { $IkiWiki::hooks{getsetup}{$id}{call}->() };
-                       next unless @s;
-                       push @ret, "", "\t# $id plugin";
-                       push @ret, dumpvalues(\%setup, @s);
-               }
-       }
-       
        unshift @ret,
                "#!/usr/bin/perl",
                "# $description",