po plugin: bugfix (calling function in wrong module)

[git.ikiwiki.info.git] / IkiWiki / Setup / Standard.pm

diff --git a/IkiWiki/Setup/Standard.pm b/IkiWiki/Setup/Standard.pm
index b8ad091448c025d3b3400b0e38b883e84754d6fa..92f887f0c4c1b565f1949b963e40da94e88c08be 100644 (file)
--- a/IkiWiki/Setup/Standard.pm
+++ b/IkiWiki/Setup/Standard.pm
@@ -10,7 +10,7 @@ use strict;
 use IkiWiki;
 
 sub import { #{{{
 use IkiWiki;
 
 sub import { #{{{

-       $IkiWiki::Setup::raw_setup=$_[1];
+       IkiWiki::Setup::merge($_[1]);

 } #}}}
 
 sub dumpline ($$$$) { #{{{
 } #}}}
 
 sub dumpline ($$$$) { #{{{


@@ -28,19 +28,28 @@ sub dumpline ($$$$) { #{{{
        local $Data::Dumper::Quotekeys=0;
        
        my $dumpedvalue;
        local $Data::Dumper::Quotekeys=0;
        
        my $dumpedvalue;

-       if ($type eq 'boolean' || $type eq 'integer') {
+       if (($type eq 'boolean' || $type eq 'integer') && $value=~/^[0-9]+$/) {

                # avoid quotes
                $dumpedvalue=$value;
        }
                # avoid quotes
                $dumpedvalue=$value;
        }

-       elsif ($type eq 'string' && ref $value eq 'ARRAY' && @$value &&
-           ! grep { /[^-A-Za-z0-9_]/ } @$value) {
+       elsif (ref $value eq 'ARRAY' && @$value && ! grep { /[^\S]/ } @$value) {

                # dump simple array as qw{}
                # dump simple array as qw{}

-               $dumpedvalue="[qw{ ".join(" ", @$value)." }]";
+               $dumpedvalue="[qw{".join(" ", @$value)."}]";

        }
        else {
                $dumpedvalue=Dumper($value);
                chomp $dumpedvalue;
        }
        else {
                $dumpedvalue=Dumper($value);
                chomp $dumpedvalue;

+               if (length $prefix) {
+                       # add to second and subsequent lines
+                       my @lines=split(/\n/, $dumpedvalue);
+                       $dumpedvalue="";
+                       for (my $x=0; $x <= $#lines; $x++) {
+                               $lines[$x] =~ s/^\t//;
+                               $dumpedvalue.="\t".($x ? $prefix : "").$lines[$x]."\n";
+                       }
+               }

                $dumpedvalue=~s/^\t//;
                $dumpedvalue=~s/^\t//;

+               chomp $dumpedvalue;

        }
        
        return "\t$prefix$key => $dumpedvalue,";
        }
        
        return "\t$prefix$key => $dumpedvalue,";


@@ -53,7 +62,7 @@ sub dumpvalues ($@) { #{{{
                my $key=shift;
                my %info=%{shift()};
 
                my $key=shift;
                my %info=%{shift()};
 

-               next if $info{type} eq "internal";
+               next if $key eq "plugin" || $info{type} eq "internal";

                
                push @ret, "\t# ".$info{description} if exists $info{description};
                
                
                push @ret, "\t# ".$info{description} if exists $info{description};
                


@@ -61,12 +70,12 @@ sub dumpvalues ($@) { #{{{
                        push @ret, dumpline($key, $setup->{$key}, $info{type}, "");
                        delete $setup->{$key};
                }
                        push @ret, dumpline($key, $setup->{$key}, $info{type}, "");
                        delete $setup->{$key};
                }

-               elsif (exists $info{default} && defined $info{default}) {
-                       push @ret, dumpline($key, $info{default}, $info{type}, "#");
-               }

                elsif (exists $info{example}) {
                        push @ret, dumpline($key, $info{example}, $info{type}, "#");
                }
                elsif (exists $info{example}) {
                        push @ret, dumpline($key, $info{example}, $info{type}, "#");
                }

+               else {
+                       push @ret, dumpline($key, "", $info{type}, "#");
+               }

        }
        return @ret;
 } #}}}
        }
        return @ret;
 } #}}}


@@ -76,26 +85,19 @@ sub gendump ($) { #{{{
        my %setup=(%config);
        my @ret;
        
        my %setup=(%config);
        my @ret;
        

-       push @ret, "\t# basic setup";
-       push @ret, dumpvalues(\%setup, IkiWiki::getsetup());
-       push @ret, "";
+       # disable logging to syslog while dumping
+       $config{syslog}=undef;

 
 

-       # sort rcs plugin first
-       my @plugins=sort {
-               ($a eq $config{rcs}) <=> ($b eq $config{rcs})
-               ||
-               $a cmp $b
-       } keys %{$IkiWiki::hooks{getsetup}};
-
-       foreach my $id (sort keys %{$IkiWiki::hooks{getsetup}}) {
-               # use an array rather than a hash, to preserve order
-               my @s=$IkiWiki::hooks{getsetup}{$id}{call}->();
-               return unless @s;
-               push @ret, "\t# $id".($id ne $config{rcs} ? " plugin" : "");
-               push @ret, dumpvalues(\%setup, @s);
-               push @ret, "";
+       push @ret, dumpvalues(\%setup, IkiWiki::getsetup());
+       foreach my $pair (IkiWiki::Setup::getsetup()) {
+               my $plugin=$pair->[0];
+               my $setup=$pair->[1];
+               my @values=dumpvalues(\%setup, @{$setup});
+               if (@values) {
+                       push @ret, "", "\t# $plugin plugin", @values;
+               }

        }
        }

-       
+

        unshift @ret,
                "#!/usr/bin/perl",
                "# $description",
        unshift @ret,
                "#!/usr/bin/perl",
                "# $description",