web commit by https://kheinz.regged.de/

[git.ikiwiki.info.git] / IkiWiki / UserInfo.pm

diff --git a/IkiWiki/UserInfo.pm b/IkiWiki/UserInfo.pm
index d48b8071cc3082ea09efad02e1e7c75e32a3b37a..cfc27609daee3f37497f4e6a8a7d2d762dc0883a 100644 (file)
--- a/IkiWiki/UserInfo.pm
+++ b/IkiWiki/UserInfo.pm
@@ -11,16 +11,23 @@ sub userinfo_retrieve () { #{{{
        my $userinfo=eval{ Storable::lock_retrieve("$config{wikistatedir}/userdb") };
        return $userinfo;
 } #}}}
-       
+
 sub userinfo_store ($) { #{{{
        my $userinfo=shift;
        
+       my $newfile="$config{wikistatedir}/userdb.new";
        my $oldmask=umask(077);
-       my $ret=Storable::lock_store($userinfo, "$config{wikistatedir}/userdb");
+       my $ret=Storable::lock_store($userinfo, $newfile);
        umask($oldmask);
+       if (defined $ret && $ret) {
+               if (! rename($newfile, "$config{wikistatedir}/userdb")) {
+                       unlink($newfile);
+                       $ret=undef;
+               }
+       }
        return $ret;
 } #}}}
-       
+
 sub userinfo_get ($$) { #{{{
        my $user=shift;
        my $field=shift;
@@ -87,12 +94,8 @@ sub set_banned_users (@) { #{{{
 
 sub commit_notify_list ($@) { #{{{
        my $committer=shift;
-       
-       my @pages;
-       foreach my $file (@_) {
-               push @pages, grep { $pagesources{$_} eq $file } keys %pagesources;
-       }
-       
+       my @pages = map pagename($_), @_;
+
        my @ret;
        my $userinfo=userinfo_retrieve();
        foreach my $user (keys %{$userinfo}) {
@@ -101,7 +104,10 @@ sub commit_notify_list ($@) { #{{{
                    length $userinfo->{$user}->{subscriptions} &&
                    exists $userinfo->{$user}->{email} &&
                    length $userinfo->{$user}->{email} &&
-                   grep { pagespec_match($_, $userinfo->{$user}->{subscriptions}) } @pages) {
+                   grep { pagespec_match($_,
+                                   $userinfo->{$user}->{subscriptions}, 
+                                   user => $committer) }
+                       map pagename($_), @_) {
                        push @ret, $userinfo->{$user}->{email};
                }
        }
@@ -125,14 +131,19 @@ sub send_commit_mails ($$$@) { #{{{
                my $diff=$diffsub->();
                my $message=$messagesub->();
 
-               my $subject="update of $config{wikiname}'s ";
+               my $pagelist;
                if (@changed_pages > 2) {
-                       $subject.="$changed_pages[0] $changed_pages[1] etc";
+                       $pagelist="$changed_pages[0] $changed_pages[1] ...";
                }
                else {
-                       $subject.=join(" ", @changed_pages);
+                       $pagelist.=join(" ", @changed_pages);
                }
-               $subject.=" by $user";
+               #translators: The three variables are the name of the wiki,
+               #translators: A list of one or more pages that were changed,
+               #translators: And the name of the user making the change.
+               #translators: This is used as the subject of a commit email.
+               my $subject=sprintf(gettext("update of %s's %s by %s"), 
+                       $config{wikiname}, $pagelist, $user);
 
                my $template=template("notifymail.tmpl");
                $template->param(
@@ -146,11 +157,10 @@ sub send_commit_mails ($$$@) { #{{{
                defined(my $pid = fork) or error("Can't fork: $!");
                return if $pid;
                setsid() or error("Can't start a new session: $!");
-               eval q{use POSIX ’setsid’};
                chdir '/';
                open STDIN, '/dev/null';
                open STDOUT, '>/dev/null';
-               open STDERR, '>&STDOUT' or error("Can’t dup stdout: $!");
+               open STDERR, '>&STDOUT' or error("Can't dup stdout: $!");
 
                unlockwiki(); # don't need to keep a lock on the wiki
 
@@ -162,7 +172,7 @@ sub send_commit_mails ($$$@) { #{{{
                                From => "$config{wikiname} <$config{adminemail}>",
                                Subject => $subject,
                                Message => $template->output,
-                       ) or error("Failed to send update notification mail");
+                       );
                }
 
                exit 0; # daemon process done