web commit by http://ethan.betacantrips.com/: clarification and related bug

[git.ikiwiki.info.git] / IkiWiki / UserInfo.pm

diff --git a/IkiWiki/UserInfo.pm b/IkiWiki/UserInfo.pm
index d48b8071cc3082ea09efad02e1e7c75e32a3b37a..267f5d9cd980d41b21750072bd92652564e2479a 100644 (file)
--- a/IkiWiki/UserInfo.pm
+++ b/IkiWiki/UserInfo.pm
@@ -125,14 +125,19 @@ sub send_commit_mails ($$$@) { #{{{
                my $diff=$diffsub->();
                my $message=$messagesub->();
 
                my $diff=$diffsub->();
                my $message=$messagesub->();
 

-               my $subject="update of $config{wikiname}'s ";
+               my $pagelist;

                if (@changed_pages > 2) {
                if (@changed_pages > 2) {

-                       $subject.="$changed_pages[0] $changed_pages[1] etc";
+                       $pagelist="$changed_pages[0] $changed_pages[1] ...";

                }
                else {
                }
                else {

-                       $subject.=join(" ", @changed_pages);
+                       $pagelist.=join(" ", @changed_pages);

                }
                }

-               $subject.=" by $user";
+               #translators: The three variables are the name of the wiki,
+               #translators: A list of one or more pages that were changed,
+               #translators: And the name of the user making the change.
+               #translators: This is used as the subject of a commit email.
+               my $subject=sprintf(gettext("update of %s's %s by %s"), 
+                       $config{wikiname}, $pagelist, $user);

 
                my $template=template("notifymail.tmpl");
                $template->param(
 
                my $template=template("notifymail.tmpl");
                $template->param(


@@ -146,11 +151,11 @@ sub send_commit_mails ($$$@) { #{{{
                defined(my $pid = fork) or error("Can't fork: $!");
                return if $pid;
                setsid() or error("Can't start a new session: $!");
                defined(my $pid = fork) or error("Can't fork: $!");
                return if $pid;
                setsid() or error("Can't start a new session: $!");

-               eval q{use POSIX ’setsid’};
+               eval q{use POSIX 'setsid'};

                chdir '/';
                open STDIN, '/dev/null';
                open STDOUT, '>/dev/null';
                chdir '/';
                open STDIN, '/dev/null';
                open STDOUT, '>/dev/null';

-               open STDERR, '>&STDOUT' or error("Can’t dup stdout: $!");
+               open STDERR, '>&STDOUT' or error("Can't dup stdout: $!");

 
                unlockwiki(); # don't need to keep a lock on the wiki
 
 
                unlockwiki(); # don't need to keep a lock on the wiki
 


@@ -162,7 +167,7 @@ sub send_commit_mails ($$$@) { #{{{
                                From => "$config{wikiname} <$config{adminemail}>",
                                Subject => $subject,
                                Message => $template->output,
                                From => "$config{wikiname} <$config{adminemail}>",
                                Subject => $subject,
                                Message => $template->output,

-                       ) or error("Failed to send update notification mail");
+                       );

                }
 
                exit 0; # daemon process done
                }
 
                exit 0; # daemon process done