review

[git.ikiwiki.info.git] / doc / todo / autoindex_should_use_add__95__autofile.mdwn

diff --git a/doc/todo/autoindex_should_use_add__95__autofile.mdwn b/doc/todo/autoindex_should_use_add__95__autofile.mdwn
index c073173f3e0db604cd8e6a31989c9efee7b3f4cb..f3fb24c16fcba3e8710c4645a23c575ee22e9814 100644 (file)
--- a/doc/todo/autoindex_should_use_add__95__autofile.mdwn
+++ b/doc/todo/autoindex_should_use_add__95__autofile.mdwn
@@ -1,9 +1,11 @@
 `add_autofile` is a generic version of [[plugins/autoindex]]'s code,
 so the latter should probably use the former. --[[smcv]]
 
 `add_autofile` is a generic version of [[plugins/autoindex]]'s code,
 so the latter should probably use the former. --[[smcv]]
 

+> [[merged|done]] --[[Joey]] 
+

 ----
 
 ----
 

-[[!template id=gitbranch branch=smcv/autoindex-autofile author="[[smcv]]"]]
+[[!template id=gitbranch branch=smcv/ready/autoindex-autofile author="[[smcv]]"]]

 
 I'm having trouble fixing this:
 
 
 I'm having trouble fixing this:
 


@@ -11,7 +13,11 @@ I'm having trouble fixing this:
        # the rest should perhaps be added to the autofile machinery
 
 By "a generic version of" above, it seems I mean "almost, but not
        # the rest should perhaps be added to the autofile machinery
 
 By "a generic version of" above, it seems I mean "almost, but not

-quite, entirely unlike". I tried digging through the git history for the
+quite, entirely unlike".
+
+> As long as it's not Tea. ;) --[[Joey]] 
+
+I tried digging through the git history for the

 reasoning behind the autofile and autoindex implementations, but now I'm
 mostly confused.
 
 reasoning behind the autofile and autoindex implementations, but now I'm
 mostly confused.
 


@@ -60,6 +66,13 @@ I'm less sure that these shouldn't create the tag page: we deleted the
 manually-created version, but that doesn't necessarily mean we don't want
 *something* to exist.
 
 manually-created version, but that doesn't necessarily mean we don't want
 *something* to exist.
 

+> That could be argued, but it's a very DWIM thing. Probably best to keep
+> the behavior simple and predictable, so one only needs to remember that
+> when a page is deleted, nothing will ever re-create it behind ones back.
+> --[[Joey]]
+
+>> Fair enough, I'll make autoindex do that. --s
+

 ## autoindex
 
 The autoindex machinery records a more complex set. Items are added to the
 ## autoindex
 
 The autoindex machinery records a more complex set. Items are added to the


@@ -98,3 +111,10 @@ and
 * delete create-del-auto; it's not added to `%deleted` because there's no
     child that would cause it to exist
 * create create-del-auto/child
 * delete create-del-auto; it's not added to `%deleted` because there's no
     child that would cause it to exist
 * create create-del-auto/child

+
+> I doubt there is any good reason for this behavior. These are probably
+> bugs. --[[Joey]] 
+
+>> OK, I believe my updated branch gives `autoindex` the same behaviour
+>> as auto-creation of tags. The `auto-del-create-del` and
+>> `create-del-auto` use cases work the same as for tags on my demo wiki. --s