Remember to run all the tests before committing!

[git.ikiwiki.info.git] / IkiWiki / Plugin / pagecount.pm

diff --git a/IkiWiki/Plugin/pagecount.pm b/IkiWiki/Plugin/pagecount.pm
index 1955603b023d84315e6c9487ea095a93ca6a6afe..dd5de3c83102aac6b806eae75a2517c622ac10e2 100644 (file)
--- a/IkiWiki/Plugin/pagecount.pm
+++ b/IkiWiki/Plugin/pagecount.pm
@@ -15,20 +15,26 @@ sub getsetup () {
                plugin => {
                        safe => 1,
                        rebuild => undef,
+                       section => "widget",
                },
 }
 
 sub preprocess (@) {
        my %params=@_;
-       $params{pages}="*" unless defined $params{pages};
+       my $pages=defined $params{pages} ? $params{pages} : "*";
        
-       # Needs to update count whenever a page is added or removed, so
-       # register a dependency.
-       add_depends($params{page}, $params{pages});
-       
-       my @pages=pagespec_match_list([keys %pagesources], $params{pages}, location => $params{page})
-               if $params{pages} ne "*"; # optimisation;
-       return $#pages+1;
+       # Just get a list of all the pages, and count the items in it.
+       # Use a presence dependency to only update when pages are added
+       # or removed.
+
+       if ($pages eq '*') {
+               # optimisation to avoid needing to try matching every page
+               add_depends($params{page}, $pages, deptype("presence"));
+               return scalar keys %pagesources;
+       }
+
+       return scalar pagespec_match_list($params{page}, $pages,
+               deptype => deptype("presence"));
 }
 
 1