Merge branch 'ready/more-magic'

[git.ikiwiki.info.git] / IkiWiki / Plugin / htmltidy.pm

diff --git a/IkiWiki/Plugin/htmltidy.pm b/IkiWiki/Plugin/htmltidy.pm
index 079da7b493d29d84b6ffdba6d4d06f0498ec88ec..da77e60f1cb6198278e87897522fd74b553f95e9 100644 (file)
--- a/IkiWiki/Plugin/htmltidy.pm
+++ b/IkiWiki/Plugin/htmltidy.pm
@@ -9,37 +9,63 @@ package IkiWiki::Plugin::htmltidy;
 
 use warnings;
 use strict;
-use IkiWiki;
+use IkiWiki 3.00;
 use IPC::Open2;
 
-sub import { #{{{
-       IkiWiki::hook(type => "sanitize", id => "tidy", call => \&sanitize);
-} # }}}
+sub import {
+       hook(type => "getsetup", id => "tidy", call => \&getsetup);
+       hook(type => "sanitize", id => "tidy", call => \&sanitize);
+       hook(type => "checkconfig", id => "tidy", call => \&checkconfig);
+}
 
-sub sanitize (@) { #{{{
-       my %params=@_;
+sub getsetup () {
+       return
+               plugin => {
+                       safe => 1,
+                       rebuild => undef,
+               },
+               htmltidy => {
+                       type => "string",
+                       description => "tidy command line",
+                       safe => 0, # path
+                       rebuild => undef,
+               },
+}
 
-       my $tries=10;
-       while (1) {
-               eval {
-                       open2(*IN, *OUT, 'tidy -quiet -asxhtml -utf8 --show-body-only yes --show-warnings no --tidy-mark no');
-               };
-               last unless $@;
-               $tries--;
-               if ($tries < 1) {
-                       IkiWiki::debug("failed to run tidy: $@");
-                       return $params{content};
-               }
+sub checkconfig () {
+       if (! defined $config{htmltidy}) {
+               $config{htmltidy}="tidy -quiet -asxhtml -utf8 --show-body-only yes --show-warnings no --tidy-mark no --markup yes";
        }
+}
+
+sub sanitize (@) {
+       my %params=@_;
+
+       return $params{content} unless defined $config{htmltidy};
+
+       my $pid;
+       my $sigpipe=0;
+       $SIG{PIPE}=sub { $sigpipe=1 };
+       $pid=open2(*IN, *OUT, "$config{htmltidy} 2>/dev/null");
+
        # open2 doesn't respect "use open ':utf8'"
-       binmode (IN, ':utf8'); 
-       binmode (OUT, ':utf8'); 
+       binmode (IN, ':utf8');
+       binmode (OUT, ':utf8');
        
        print OUT $params{content};
        close OUT;
 
        local $/ = undef;
-       return <IN>;
-} # }}}
+       my $ret=<IN>;
+       close IN;
+       waitpid $pid, 0;
+
+       $SIG{PIPE}="DEFAULT";
+       if ($sigpipe || ! defined $ret) {
+               return gettext("htmltidy failed to parse this html");
+       }
+
+       return $ret;
+}
 
 1