po: avoid warnings and possible bugs with nested named subroutines

[git.ikiwiki.info.git] / IkiWiki / Plugin / smiley.pm

diff --git a/IkiWiki/Plugin/smiley.pm b/IkiWiki/Plugin/smiley.pm
index 7a9026025ed94f778aa4b6e666677b27595f605b..1697a37c1981d0520f1966a53cd647324fcb2ba8 100644 (file)
--- a/IkiWiki/Plugin/smiley.pm
+++ b/IkiWiki/Plugin/smiley.pm
@@ -3,18 +3,18 @@ package IkiWiki::Plugin::smiley;
 
 use warnings;
 use strict;
 
 use warnings;
 use strict;

-use IkiWiki 2.00;
+use IkiWiki 3.00;

 
 my %smileys;
 my $smiley_regexp;
 
 
 my %smileys;
 my $smiley_regexp;
 

-sub import { #{{{
+sub import {

        add_underlay("smiley");
        hook(type => "getsetup", id => "smiley", call => \&getsetup);
        hook(type => "sanitize", id => "smiley", call => \&sanitize);
        add_underlay("smiley");
        hook(type => "getsetup", id => "smiley", call => \&getsetup);
        hook(type => "sanitize", id => "smiley", call => \&sanitize);

-} # }}}
+}

 
 

-sub getsetup () { #{{{
+sub getsetup () {

        return
                plugin => {
                        safe => 1,
        return
                plugin => {
                        safe => 1,


@@ -22,9 +22,9 @@ sub getsetup () { #{{{
                        # removes the smileys, which would break links
                        rebuild => 1,
                },
                        # removes the smileys, which would break links
                        rebuild => 1,
                },

-} #}}}
+}

 
 

-sub build_regexp () { #{{{
+sub build_regexp () {

        my $list=readfile(srcfile("smileys.mdwn"));
        while ($list =~ m/^\s*\*\s+\\\\([^\s]+)\s+\[\[([^]]+)\]\]/mg) {
                my $smiley=$1;
        my $list=readfile(srcfile("smileys.mdwn"));
        while ($list =~ m/^\s*\*\s+\\\\([^\s]+)\s+\[\[([^]]+)\]\]/mg) {
                my $smiley=$1;


@@ -50,9 +50,9 @@ sub build_regexp () { #{{{
        $smiley_regexp='('.join('|', map { quotemeta }
                reverse sort keys %smileys).')';
        #debug($smiley_regexp);
        $smiley_regexp='('.join('|', map { quotemeta }
                reverse sort keys %smileys).')';
        #debug($smiley_regexp);

-} #}}}
+}

 
 

-sub sanitize (@) { #{{{
+sub sanitize (@) {

        my %params=@_;
 
        build_regexp() unless defined $smiley_regexp;
        my %params=@_;
 
        build_regexp() unless defined $smiley_regexp;


@@ -92,13 +92,9 @@ MATCH:       while (m{(?:^|(?<=\s|>))(\\?)$smiley_regexp(?:(?=\s|<)|$)}g) {
                                         $smileys{$smiley}, linktext => $smiley);
                        pos=$epos+1;
                }
                                         $smileys{$smiley}, linktext => $smiley);
                        pos=$epos+1;
                }

-
-               # Breaks out at end, otherwise it will scan through again,
-               # replacing de-escaped ones.
-               #last unless defined pos;

        }
 
        return $_;
        }
 
        return $_;

-} # }}}
+}

 
 1
 
 1