Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

[git.ikiwiki.info.git] / IkiWiki / Plugin / comments.pm

diff --git a/IkiWiki/Plugin/comments.pm b/IkiWiki/Plugin/comments.pm
index de193bd12b358d2850a823c3e492af1844b4a292..17cd99c3b92008b0ee4f35c4ca8f3aaaabe2df7d 100644 (file)
--- a/IkiWiki/Plugin/comments.pm
+++ b/IkiWiki/Plugin/comments.pm
@@ -433,7 +433,8 @@ sub editcomment ($$) {
 
        $content .= " date=\"" . decode_utf8(strftime('%Y-%m-%dT%H:%M:%SZ', gmtime)) . "\"\n";
 
 
        $content .= " date=\"" . decode_utf8(strftime('%Y-%m-%dT%H:%M:%SZ', gmtime)) . "\"\n";
 

-       my $editcontent = $form->field('editcontent') || '';
+       my $editcontent = $form->field('editcontent');
+       $editcontent="" if ! defined $editcontent;

        $editcontent =~ s/\r\n/\n/g;
        $editcontent =~ s/\r/\n/g;
        $editcontent =~ s/"/\\"/g;
        $editcontent =~ s/\r\n/\n/g;
        $editcontent =~ s/\r/\n/g;
        $editcontent =~ s/"/\\"/g;


@@ -536,7 +537,7 @@ sub editcomment ($$) {
        }
        else {
                IkiWiki::showform ($form, \@buttons, $session, $cgi,
        }
        else {
                IkiWiki::showform ($form, \@buttons, $session, $cgi,

-                       forcebaseurl => $baseurl);
+                       forcebaseurl => $baseurl, page => $page);

        }
 
        exit;
        }
 
        exit;


@@ -659,16 +660,22 @@ sub comments_pending () {
 
        eval q{use File::Find};
        error($@) if $@;
 
        eval q{use File::Find};
        error($@) if $@;

+       eval q{use Cwd};
+       error($@) if $@;
+       my $origdir=getcwd();

 
        my $find_comments=sub {
                my $dir=shift;
                my $extension=shift;
                return unless -d $dir;
 
        my $find_comments=sub {
                my $dir=shift;
                my $extension=shift;
                return unless -d $dir;

+
+               chdir($dir) || die "chdir: $!";
+

                find({
                        no_chdir => 1,
                        wanted => sub {
                                my $file=decode_utf8($_);
                find({
                        no_chdir => 1,
                        wanted => sub {
                                my $file=decode_utf8($_);

-                               $file=~s/^\Q$dir\E\/?//;
+                               $file=~s/^\.\///;

                                return if ! length $file || IkiWiki::file_pruned($file)
                                        || -l $_ || -d _ || $file !~ /\Q$extension\E$/;
                                my ($f) = $file =~ /$config{wiki_file_regexp}/; # untaint
                                return if ! length $file || IkiWiki::file_pruned($file)
                                        || -l $_ || -d _ || $file !~ /\Q$extension\E$/;
                                my ($f) = $file =~ /$config{wiki_file_regexp}/; # untaint


@@ -677,7 +684,9 @@ sub comments_pending () {
                                        push @ret, [$f, $dir, $ctime];
                                }
                        }
                                        push @ret, [$f, $dir, $ctime];
                                }
                        }

-               }, $dir);
+               }, ".");
+
+               chdir($origdir) || die "chdir: $!";

        };
        
        $find_comments->($config{srcdir}, "._comment_pending");
        };
        
        $find_comments->($config{srcdir}, "._comment_pending");


@@ -913,8 +922,8 @@ sub match_comment ($$;@) {
        my $source=exists $IkiWiki::pagesources{$page} ?
                $IkiWiki::pagesources{$page} :
                $IkiWiki::delpagesources{$page};
        my $source=exists $IkiWiki::pagesources{$page} ?
                $IkiWiki::pagesources{$page} :
                $IkiWiki::delpagesources{$page};

-       my $type=IkiWiki::pagetype($source);
-       if (defined $type && $type ne "_comment") {
+       my $type=defined $source ? IkiWiki::pagetype($source) : undef;
+       if (! defined $type || $type ne "_comment") {

                return IkiWiki::FailReason->new("$page is not a comment");
        }
 
                return IkiWiki::FailReason->new("$page is not a comment");
        }
 


@@ -928,8 +937,8 @@ sub match_comment_pending ($$;@) {
        my $source=exists $IkiWiki::pagesources{$page} ?
                $IkiWiki::pagesources{$page} :
                $IkiWiki::delpagesources{$page};
        my $source=exists $IkiWiki::pagesources{$page} ?
                $IkiWiki::pagesources{$page} :
                $IkiWiki::delpagesources{$page};

-       my $type=IkiWiki::pagetype($source);
-       if (defined $type && $type ne "_comment_pending") {
+       my $type=defined $source ? IkiWiki::pagetype($source) : undef;
+       if (! defined $type || $type ne "_comment_pending") {

                return IkiWiki::FailReason->new("$page is not a pending comment");
        }
 
                return IkiWiki::FailReason->new("$page is not a pending comment");
        }