Note todo with patch attached to solve listed problem

[git.ikiwiki.info.git] / IkiWiki / UserInfo.pm

diff --git a/IkiWiki/UserInfo.pm b/IkiWiki/UserInfo.pm
index cfc27609daee3f37497f4e6a8a7d2d762dc0883a..0bf100a959c934d23c8f73ac1f0962f856732a35 100644 (file)
--- a/IkiWiki/UserInfo.pm
+++ b/IkiWiki/UserInfo.pm
@@ -1,23 +1,23 @@
 #!/usr/bin/perl
 
 #!/usr/bin/perl
 

+package IkiWiki;
+

 use warnings;
 use strict;
 use Storable;
 use IkiWiki;
 
 use warnings;
 use strict;
 use Storable;
 use IkiWiki;
 

-package IkiWiki;
-
-sub userinfo_retrieve () { #{{{
+sub userinfo_retrieve () {

        my $userinfo=eval{ Storable::lock_retrieve("$config{wikistatedir}/userdb") };
        return $userinfo;
        my $userinfo=eval{ Storable::lock_retrieve("$config{wikistatedir}/userdb") };
        return $userinfo;

-} #}}}
+}

 
 

-sub userinfo_store ($) { #{{{
+sub userinfo_store ($) {

        my $userinfo=shift;
        
        my $newfile="$config{wikistatedir}/userdb.new";
        my $oldmask=umask(077);
        my $userinfo=shift;
        
        my $newfile="$config{wikistatedir}/userdb.new";
        my $oldmask=umask(077);

-       my $ret=Storable::lock_store($userinfo, $newfile);
+       my $ret=Storable::lock_nstore($userinfo, $newfile);

        umask($oldmask);
        if (defined $ret && $ret) {
                if (! rename($newfile, "$config{wikistatedir}/userdb")) {
        umask($oldmask);
        if (defined $ret && $ret) {
                if (! rename($newfile, "$config{wikistatedir}/userdb")) {


@@ -26,9 +26,9 @@ sub userinfo_store ($) { #{{{
                }
        }
        return $ret;
                }
        }
        return $ret;

-} #}}}
+}

 
 

-sub userinfo_get ($$) { #{{{
+sub userinfo_get ($$) {

        my $user=shift;
        my $field=shift;
 
        my $user=shift;
        my $field=shift;
 


@@ -39,9 +39,9 @@ sub userinfo_get ($$) { #{{{
                return "";
        }
        return $userinfo->{$user}->{$field};
                return "";
        }
        return $userinfo->{$user}->{$field};

-} #}}}
+}

 
 

-sub userinfo_set ($$$) { #{{{
+sub userinfo_set ($$$) {

        my $user=shift;
        my $field=shift;
        my $value=shift;
        my $user=shift;
        my $field=shift;
        my $value=shift;


@@ -54,9 +54,9 @@ sub userinfo_set ($$$) { #{{{
        
        $userinfo->{$user}->{$field}=$value;
        return userinfo_store($userinfo);
        
        $userinfo->{$user}->{$field}=$value;
        return userinfo_store($userinfo);

-} #}}}
+}

 
 

-sub userinfo_setall ($$) { #{{{
+sub userinfo_setall ($$) {

        my $user=shift;
        my $info=shift;
        
        my $user=shift;
        my $info=shift;
        


@@ -66,117 +66,12 @@ sub userinfo_setall ($$) { #{{{
        }
        $userinfo->{$user}=$info;
        return userinfo_store($userinfo);
        }
        $userinfo->{$user}=$info;
        return userinfo_store($userinfo);

-} #}}}
+}

 
 

-sub is_admin ($) { #{{{
+sub is_admin ($) {

        my $user_name=shift;
 
        return grep { $_ eq $user_name } @{$config{adminuser}};
        my $user_name=shift;
 
        return grep { $_ eq $user_name } @{$config{adminuser}};

-} #}}}
-
-sub get_banned_users () { #{{{
-       my @ret;
-       my $userinfo=userinfo_retrieve();
-       foreach my $user (keys %{$userinfo}) {
-               push @ret, $user if $userinfo->{$user}->{banned};
-       }
-       return @ret;
-} #}}}
-
-sub set_banned_users (@) { #{{{
-       my %banned=map { $_ => 1 } @_;
-       my $userinfo=userinfo_retrieve();
-       foreach my $user (keys %{$userinfo}) {
-               $userinfo->{$user}->{banned} = $banned{$user};
-       }
-       return userinfo_store($userinfo);
-} #}}}
-
-sub commit_notify_list ($@) { #{{{
-       my $committer=shift;
-       my @pages = map pagename($_), @_;
-
-       my @ret;
-       my $userinfo=userinfo_retrieve();
-       foreach my $user (keys %{$userinfo}) {
-               next if $user eq $committer;
-               if (exists $userinfo->{$user}->{subscriptions} &&
-                   length $userinfo->{$user}->{subscriptions} &&
-                   exists $userinfo->{$user}->{email} &&
-                   length $userinfo->{$user}->{email} &&
-                   grep { pagespec_match($_,
-                                   $userinfo->{$user}->{subscriptions}, 
-                                   user => $committer) }
-                       map pagename($_), @_) {
-                       push @ret, $userinfo->{$user}->{email};
-               }
-       }
-       return @ret;
-} #}}}
-
-sub send_commit_mails ($$$@) { #{{{
-       my $messagesub=shift;
-       my $diffsub=shift;
-       my $user=shift;
-       my @changed_pages=@_;
-
-       return unless @changed_pages;
-
-       my @email_recipients=commit_notify_list($user, @changed_pages);
-       if (@email_recipients) {
-               # TODO: if a commit spans multiple pages, this will send
-               # subscribers a diff that might contain pages they did not
-               # sign up for. Should separate the diff per page and
-               # reassemble into one mail with just the pages subscribed to.
-               my $diff=$diffsub->();
-               my $message=$messagesub->();
-
-               my $pagelist;
-               if (@changed_pages > 2) {
-                       $pagelist="$changed_pages[0] $changed_pages[1] ...";
-               }
-               else {
-                       $pagelist.=join(" ", @changed_pages);
-               }
-               #translators: The three variables are the name of the wiki,
-               #translators: A list of one or more pages that were changed,
-               #translators: And the name of the user making the change.
-               #translators: This is used as the subject of a commit email.
-               my $subject=sprintf(gettext("update of %s's %s by %s"), 
-                       $config{wikiname}, $pagelist, $user);
-
-               my $template=template("notifymail.tmpl");
-               $template->param(
-                       wikiname => $config{wikiname},
-                       diff => $diff,
-                       user => $user,
-                       message => $message,
-               );
-
-               # Daemonize, in case the mail sending takes a while.
-               defined(my $pid = fork) or error("Can't fork: $!");
-               return if $pid;
-               setsid() or error("Can't start a new session: $!");
-               chdir '/';
-               open STDIN, '/dev/null';
-               open STDOUT, '>/dev/null';
-               open STDERR, '>&STDOUT' or error("Can't dup stdout: $!");
-
-               unlockwiki(); # don't need to keep a lock on the wiki
-
-               eval q{use Mail::Sendmail};
-               error($@) if $@;
-               foreach my $email (@email_recipients) {
-                       sendmail(
-                               To => $email,
-                               From => "$config{wikiname} <$config{adminemail}>",
-                               Subject => $subject,
-                               Message => $template->output,
-                       );
-               }
-
-               exit 0; # daemon process done
-       }
-} #}}}
+}

 
 1
 
 1