po todo update: this has been fixed already.

[git.ikiwiki.info.git] / doc / todo / CSS_classes_for_links.mdwn

diff --git a/doc/todo/CSS_classes_for_links.mdwn b/doc/todo/CSS_classes_for_links.mdwn
index 0c5e4036bdc8aa13ffc80a4332e4961342af9858..38db87724a9871cad7f37dbb497752e81d8413b5 100644 (file)
--- a/doc/todo/CSS_classes_for_links.mdwn
+++ b/doc/todo/CSS_classes_for_links.mdwn
@@ -52,6 +52,8 @@ My best regards,
 >>> I also think this should be in an external plugin, not in ikiwiki.
 >>>
 
 >>> I also think this should be in an external plugin, not in ikiwiki.
 >>>
 

+I find CSS3 support still spotty...  Here are some notes on how to do this in IkiWiki with jQuery: <http://iki.u32.net/setup/External_Links> --[[sabr]]
+

 > If you need to achieve this in IkiWiki itself, I imagine you could create a
 > plugin which runs in the `format` phase of rendering and search/replaces
 > specific link patterns.  This should be a fairly simple exercise in regular
 > If you need to achieve this in IkiWiki itself, I imagine you could create a
 > plugin which runs in the `format` phase of rendering and search/replaces
 > specific link patterns.  This should be a fairly simple exercise in regular


@@ -73,3 +75,29 @@ My best regards,
 > [[rel_attribute|rel_attribute_for_links]] now that CSS can use.)
 > 
 > --[[Joey]]
 > [[rel_attribute|rel_attribute_for_links]] now that CSS can use.)
 > 
 > --[[Joey]]

+
+>> I had a little look at this, last weekend. I added a class definition to
+>> the `htmllink` call in `linkify` in `link.pm`. It works pretty well, but
+>> I'd also need to adjust other `htmllink` calls (map, inline, etc.). I found
+>> other methods (CSS3 selectors, etc.) to be unreliable.
+>> 
+>> Would you potentially accept a patch that added `class="internal"` to
+>> various `htmllink` calls in ikiwiki?
+>> 
+>> How configurable do you think this behaviour should be? I'm considering a
+>> config switch to enable or disable this behaviour, or possibly a
+>> configurable list of class names to append for internal links (defaulting
+>> to an empty list for backwards compatibility)>
+>> 
+>> As an alternative to patching the uses of `htmllink`, what do you think
+>> about patching `htmllink` itself? Are there circumstances where it might be
+>> used to generate a non-internal link? -- [[Jon]]
+
+>>> I think that the minimum configurability to get something that
+>>> can be used by CSS to style the links however the end user wants
+>>> is the best thing to shoot for. Ideally, no configurability. And
+>>> a tip or something documenting how to use the classes in your CSS
+>>> to style links so that eg, external links have a warning icon.
+>>> 
+>>> `htmllink` can never be used to generate an external link. So,
+>>> patching it seems the best approach. --[[Joey]]