optimize for common case where list is not changed

[git.ikiwiki.info.git] / doc / bugs / Http_error_500_when_using_mercurial_backend.mdwn

diff --git a/doc/bugs/Http_error_500_when_using_mercurial_backend.mdwn b/doc/bugs/Http_error_500_when_using_mercurial_backend.mdwn
index 5015b62903aec144d962f67609b615585806ccd2..638def33787d228a8c9fccf2767d751fdc3f5036 100644 (file)
--- a/doc/bugs/Http_error_500_when_using_mercurial_backend.mdwn
+++ b/doc/bugs/Http_error_500_when_using_mercurial_backend.mdwn
@@ -1,3 +1,5 @@
+This is [[done]]
+
 The mercurial backend is broken when no changelog message is given.
 
 Here is a quick patch, partialy copying the svn backend. 
@@ -19,4 +21,11 @@ Here is a quick patch, partialy copying the svn backend.
     +          $message="web commit by Anonymous".(length $message ? ": $message" : "");
        }
      
-       $message = possibly_foolish_untaint($message);
\ No newline at end of file
+       $message = possibly_foolish_untaint($message);
+
+> The svn backend puts the user info in the message because that's the only
+> way to store the user info, unlike with mercurial. The svn plugin also
+> removes that info when getting the RecentChanges info. Since mercurial
+> does not do that, it seemed better to me to test for an empty message and
+> set it to a dummy commit string, which I've [[bugs/done]]. --[[Joey]]
+>>Thanks for the correct fix, Joey. --hb
\ No newline at end of file