comment about comments

[git.ikiwiki.info.git] / doc / bugs / git_stderr_output_causes_problems.mdwn

diff --git a/doc/bugs/git_stderr_output_causes_problems.mdwn b/doc/bugs/git_stderr_output_causes_problems.mdwn
index e86b7842f653960bfa05be2611aa2e5fecd9c1f0..c25ef69278215e0de14120c437b3b8eb613521bc 100644 (file)
--- a/doc/bugs/git_stderr_output_causes_problems.mdwn
+++ b/doc/bugs/git_stderr_output_causes_problems.mdwn
@@ -6,7 +6,7 @@ Ikiwiki's git handling is sending a bunch of output to stderr.  The following pa
     index 425536f..5734bb2 100644
     --- a/IkiWiki/Rcs/git.pm
     +++ b/IkiWiki/Rcs/git.pm
     index 425536f..5734bb2 100644
     --- a/IkiWiki/Rcs/git.pm
     +++ b/IkiWiki/Rcs/git.pm

-    @@ -24,6 +24,7 @@ sub _safe_git (&@) { #{{{
+    @@ -24,6 +24,7 @@ sub _safe_git (&@) {

             if (!$pid) {
                     # In child.
                     # Git commands want to be in wc.
             if (!$pid) {
                     # In child.
                     # Git commands want to be in wc.


@@ -31,3 +31,12 @@ Ikiwiki's git handling is sending a bunch of output to stderr.  The following pa
 >
 > (Also indented all the lines of your patch so markdown won't eat it :-) )
 > --[[smcv]]
 >
 > (Also indented all the lines of your patch so markdown won't eat it :-) )
 > --[[smcv]]

+
+> Right, I don't like throwing stderr away because stderr is supposed to be
+> logged to error.log for a reason: To allow debugging problems.
+> It's unfortunate that git [abuses atderr](http://bugs.debian.org/447395),
+> outputting non-errors to it. That doesn't mean that git might not also
+> output actual error messages there. --[[Joey]]
+
+>> I'm happy with the wrapper script solution, so this is [[done]].
+>> And this report is now here to point others to that solution.