link changes

[git.ikiwiki.info.git] / IkiWiki / Plugin / rename.pm

diff --git a/IkiWiki/Plugin/rename.pm b/IkiWiki/Plugin/rename.pm
index 38cebdba50d6e0c4a58376f0738c3df44a031103..8dad92be3e8794c2ef09ed4a518f814fb49be2a5 100644 (file)
--- a/IkiWiki/Plugin/rename.pm
+++ b/IkiWiki/Plugin/rename.pm
@@ -10,7 +10,7 @@ sub import {
        hook(type => "formbuilder_setup", id => "rename", call => \&formbuilder_setup);
        hook(type => "formbuilder", id => "rename", call => \&formbuilder);
        hook(type => "sessioncgi", id => "rename", call => \&sessioncgi);
-       hook(type => "rename", id => "rename", call => \&rename);
+       hook(type => "rename", id => "rename", call => \&rename_subpages);
 }
 
 sub getsetup () {
@@ -318,8 +318,6 @@ sub sessioncgi ($$) {
                                cgi => $q,
                                session => $session,
                        );
-                       # FIXME: remove duplicates (based on src or srcfile key)
-                       # from @torename
 
                        require IkiWiki::Render;
                        IkiWiki::disable_commit_hook() if $config{rcs};
@@ -416,7 +414,7 @@ sub sessioncgi ($$) {
 }
 
 # Add subpages to the list of pages to be renamed, if needed.
-sub rename(@) {
+sub rename_subpages (@) {
        my %params = @_;
 
        my %torename = %{$params{torename}};
@@ -488,33 +486,34 @@ sub rename_hook (@) {
        my $q=$params{cgi};
        my $session=$params{session};
 
+       return () unless @torename;
+
        my @nextset;
-       if (@torename) {
-               foreach my $torename (@torename) {
-                       unless (exists $done{$torename->{src}} && $done{$torename->{src}}) {
-                               IkiWiki::run_hooks(rename => sub {
-                                       push @nextset, shift->(
-                                               torename => $torename,
-                                               cgi => $q,
-                                               session => $session,
-                                       );
-                               });
-                               $done{$torename->{src}}=1;
-                       }
+       foreach my $torename (@torename) {
+               unless (exists $done{$torename->{src}} && $done{$torename->{src}}) {
+                       IkiWiki::run_hooks(rename => sub {
+                               push @nextset, shift->(
+                                       torename => $torename,
+                                       cgi => $q,
+                                       session => $session,
+                               );
+                       });
+                       $done{$torename->{src}}=1;
                }
-               push @torename, rename_hook(
-                       torename => \@nextset,
-                       done => \%done,
-                       cgi => $q,
-                       session => $session,
-               );
-               return @torename;
-       }
-       else {
-               return ();
        }
+
+       push @torename, rename_hook(
+               torename => \@nextset,
+               done => \%done,
+               cgi => $q,
+               session => $session,
+       );
+
+       # dedup
+       my %seen;
+       return grep { ! $seen{$_->{src}}++ } @torename;
 }
-                       
+
 sub do_rename ($$$) {
        my $rename=shift;
        my $q=shift;
@@ -534,7 +533,7 @@ sub do_rename ($$$) {
                IkiWiki::rcs_rename($rename->{srcfile}, $rename->{destfile});
        }
        else {
-               if (! CORE::rename($config{srcdir}."/".$rename->{srcfile},
+               if (! rename($config{srcdir}."/".$rename->{srcfile},
                             $config{srcdir}."/".$rename->{destfile})) {
                        error("rename: $!");
                }