reinstate linebreak

[git.ikiwiki.info.git] / doc / bugs / notifyemail_fails_with_some_openid_providers.mdwn

diff --git a/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn b/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn
index 5c5b01431f0af81db8d7c635095beb9f1f1ccde1..90e2c790065ff11ccb5f54ccb37f8639998daa64 100644 (file)
--- a/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn
+++ b/doc/bugs/notifyemail_fails_with_some_openid_providers.mdwn
@@ -1,3 +1,5 @@
+[[!template  id=gitbranch branch=anarcat/dev/openid_email author="[[anarcat]]"]]
+

 This bug affects [[plugins/notifyemail]] but is probably caused more by [[plugins/openid]]. When using OpenID to login to a site, no email notification is sent to the user (pagespec set to `*`) when a modification is done on the wiki. I believe this is because the OpenID plugin assumes the email comes from the OpenID provider - which is not necessarily going to succeed if, for privacy reason, the OpenID provider refuses to transmit the email to ikiwiki.
 
 In the OpenID plugin, the email is actually fetched when authenticating and is stored in the session, like so:
 This bug affects [[plugins/notifyemail]] but is probably caused more by [[plugins/openid]]. When using OpenID to login to a site, no email notification is sent to the user (pagespec set to `*`) when a modification is done on the wiki. I believe this is because the OpenID plugin assumes the email comes from the OpenID provider - which is not necessarily going to succeed if, for privacy reason, the OpenID provider refuses to transmit the email to ikiwiki.
 
 In the OpenID plugin, the email is actually fetched when authenticating and is stored in the session, like so:


@@ -56,23 +58,10 @@ sub formbuilder_setup (@) {
 
 I believe this could be worked around simply by re-enabling that field and allowing the user to specify an email there by hand, making a note that the OpenID provider's email is used by default.
 
 
 I believe this could be worked around simply by re-enabling that field and allowing the user to specify an email there by hand, making a note that the OpenID provider's email is used by default.
 

-Here's the dumbest [[!taglink patch]] that actually fixes the problem for me:
-
-[[!format diff """
-diff --git a/IkiWiki/Plugin/openid.pm b/IkiWiki/Plugin/openid.pm
-index e3b9982..df87ba3 100644
---- a/IkiWiki/Plugin/openid.pm
-+++ b/IkiWiki/Plugin/openid.pm
-@@ -104,7 +104,6 @@ sub formbuilder_setup (@) {
-                       size => 1, force => 1,
-                       fieldset => "login",
-                       comment => $session->param("name"));
--              $form->field(name => "email", type => "hidden");
-       }
- }
- 
-"""]]
+The dumbest [[!taglink patch]] that actually fixes the problem for me is in the branch mentionned above.

 
 It would probably be better to add a comment on the field as indicated above, but it's a good proof of concept.
 
 Any other ideas? --[[anarcat]]
 
 It would probably be better to add a comment on the field as indicated above, but it's a good proof of concept.
 
 Any other ideas? --[[anarcat]]

+
+> Note: it seems that my email *is* given by my OpenID provider, no idea why this is not working, but the fix proposed in my branch works. --[[anarcat]]