1 [[!template id=gitbranch branch=smcv/trail author=smcv]] [[!tag patch]]
3 `t/trail.t` has some test suite failures. This is after applying
4 [[smcv]]'s patch that fixed some races that caused it to fail
5 sometimes. These remaining failures may also be intermittant,
6 although I can get them reliably on my laptop. I've added some debugging
7 output, which seems to point to an actual bug in the plugin AFAICS. --[[Joey]]
9 > I can reproduce this reliably at 0a23666ddd but not 3.20120203. Bisecting
10 > indicates that it regressed in aaa72a3a80f, "inline: When the pagenames list
11 > includes pages that do not exist, skip them".
13 > I don't think this is the bug noted in the commit message - the inline
14 > containing `sorting/new` uses `pages`, not `pagenames`. --[[smcv]]
16 >> It seems you removed `trail` support from `inline` in that commit.
17 >> Assuming that wasn't intentional, this is fixed in `smcv/trail`.
21 ok 71 - expected n=sorting/end p=sorting/beginning in sorting/middle.html
22 not ok 72 - expected n=sorting/new p=sorting/middle in sorting/end.html
23 # Failed test 'expected n=sorting/new p=sorting/middle in sorting/end.html'
24 # at t/trail.t line 13.
25 # got: 'n=sorting/linked2 p=sorting/middle'
26 # expected: 'n=sorting/new p=sorting/middle'
27 not ok 73 - expected n=sorting/old p=sorting/end in sorting/new.html
28 # Failed test 'expected n=sorting/old p=sorting/end in sorting/new.html'
29 # at t/trail.t line 13.
31 # expected: 'n=sorting/old p=sorting/end'
32 not ok 74 - expected n=sorting/ancient p=sorting/new in sorting/old.html
33 # Failed test 'expected n=sorting/ancient p=sorting/new in sorting/old.html'
34 # at t/trail.t line 13.
36 # expected: 'n=sorting/ancient p=sorting/new'
37 not ok 75 - expected n=sorting/linked2 p=sorting/old in sorting/ancient.html
38 # Failed test 'expected n=sorting/linked2 p=sorting/old in sorting/ancient.html'
39 # at t/trail.t line 13.
41 # expected: 'n=sorting/linked2 p=sorting/old'
42 not ok 76 - expected n= p=sorting/ancient in sorting/linked2.html
43 # Failed test 'expected n= p=sorting/ancient in sorting/linked2.html'
44 # at t/trail.t line 13.
45 # got: 'n= p=sorting/end'
46 # expected: 'n= p=sorting/ancient'
50 Here, the "new" page does not seem to be included into the trail as expected.
51 Looking at the rendered page, there is no trail directive output on it either.
56 not ok 91 - expected n=sorting/new p= in sorting/old.html
57 # Failed test 'expected n=sorting/new p= in sorting/old.html'
58 # at t/trail.t line 13.
60 # expected: 'n=sorting/new p='
61 not ok 92 - expected n=sorting/middle p=sorting/old in sorting/new.html
62 # Failed test 'expected n=sorting/middle p=sorting/old in sorting/new.html'
63 # at t/trail.t line 13.
65 # expected: 'n=sorting/middle p=sorting/old'
66 not ok 93 - expected n=sorting/linked2 p=sorting/new in sorting/middle.html
67 # Failed test 'expected n=sorting/linked2 p=sorting/new in sorting/middle.html'
68 # at t/trail.t line 13.
69 # got: 'n=sorting/linked2 p='
70 # expected: 'n=sorting/linked2 p=sorting/new'
71 ok 94 - expected n=sorting/linked p=sorting/middle in sorting/linked2.html
72 ok 95 - expected n=sorting/end p=sorting/linked2 in sorting/linked.html
73 ok 96 - expected n=sorting/a/c p=sorting/linked in sorting/end.html
74 ok 97 - expected n=sorting/beginning p=sorting/end in sorting/a/c.html
75 ok 98 - expected n=sorting/a/b p=sorting/a/c in sorting/beginning.html
76 not ok 99 - expected n=sorting/ancient p=sorting/beginning in sorting/a/b.html
77 # Failed test 'expected n=sorting/ancient p=sorting/beginning in sorting/a/b.html'
78 # at t/trail.t line 13.
79 # got: 'n=sorting/z/a p=sorting/beginning'
80 # expected: 'n=sorting/ancient p=sorting/beginning'
81 not ok 100 - expected n=sorting/z/a p=sorting/a/b in sorting/ancient.html
82 # Failed test 'expected n=sorting/z/a p=sorting/a/b in sorting/ancient.html'
83 # at t/trail.t line 13.
85 # expected: 'n=sorting/z/a p=sorting/a/b'
86 not ok 101 - expected n= p=sorting/ancient in sorting/z/a.html
87 # Failed test 'expected n= p=sorting/ancient in sorting/z/a.html'
88 # at t/trail.t line 13.
89 # got: 'n= p=sorting/a/b'
90 # expected: 'n= p=sorting/ancient'
94 Haven't investigated, but looks like the same sort of problem, a
95 page expected to be in the trail isn't. --[[Joey]]