1 Table directive can not deal with Chinese, when format csv
3 \[[!table format=csv data="""
9 But the below example works well.
11 \[[!table format=csv data="""
18 The below example works well too
20 \[[!table format=dsv delimiter=, data="""
28 > You don't say what actually happens when you try this, but I hit something similar trying unicode symbols in a CSV-based table. (I wasn't aware of the DSV work-around. Thanks!) The specific error I get trying is
30 [\[!table Error: Cannot decode string with wide characters at /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 243.]]
32 > That file is owned by the `libperl5` package, but I think I've seen an error mentioning `Text::CSV` i.e. `libtext-csv-perl` when I've encountered this before. -- [[Jon]]
34 >> A related problem, also fixed by using DSV, is messing up the encoding of non-ASCII, non-wide characters, e.g. £ (workaround was to use £ instead) -- [[Jon]]
36 >>> Sorry, I have faced the same error: \[[!table Error: Cannot decode string with wide characters at /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 243.]] -- [[tumashu1]]
40 The below patch seem to deal with this problem:
42 From d6ed90331b31e4669222c6831f7a0f40f0677fe1 Mon Sep 17 00:00:00 2001
43 From: Feng Shu <tumashu@163.com>
44 Date: Sun, 2 Dec 2018 08:41:39 +0800
45 Subject: [PATCH 2/2] Fix table plugin can handle UTF-8 csv format
48 IkiWiki/Plugin/table.pm | 3 ++-
49 1 file changed, 2 insertions(+), 1 deletion(-)
51 From ad1a92c796d907ad293e572a168b6e9a8219623f Mon Sep 17 00:00:00 2001
52 From: Feng Shu <tumashu@163.com>
53 Date: Sun, 2 Dec 2018 08:41:39 +0800
54 Subject: [PATCH 2/2] Fix table plugin can handle UTF-8 csv format
57 IkiWiki/Plugin/table.pm | 3 ++-
58 1 file changed, 2 insertions(+), 1 deletion(-)
60 diff --git a/IkiWiki/Plugin/table.pm b/IkiWiki/Plugin/table.pm
61 index f3c425a37..7fea8ab1c 100644
62 --- a/IkiWiki/Plugin/table.pm
63 +++ b/IkiWiki/Plugin/table.pm
64 @@ -135,6 +135,7 @@ sub split_csv ($$) {
65 my $csv = Text::CSV->new({
66 sep_char => $delimiter,
69 allow_loose_quotes => 1,
70 }) || error("could not create a Text::CSV object");
72 @@ -143,7 +144,7 @@ sub split_csv ($$) {
73 foreach my $line (@text_lines) {
75 if ($csv->parse($line)) {
76 - push(@data, [ map { decode_utf8 $_ } $csv->fields() ]);
77 + push(@data, [ $csv->fields() ]);
80 debug(sprintf(gettext('parse fail at line %d: %s'),
84 > Thanks, I've applied that patch and added test coverage. [[done]] --[[smcv]]
88 I can confirm that the above patch fixes the issue for me. Thanks! I'm not an ikiwiki committer, but I would encourage them to consider the above. Whilst I'm at it, I would be *really* grateful for some input on [[todo/support_multi-row_table_headers]] which relates to the same plugin. [[Jon]]
92 I've hit this bug with an inline-table and 3.20190228-1 (so: patch applied), with the following definition
94 [[\!table class=fullwidth_table delimiter=" " data="""
96 Number Title Own? Read?
97 I (HB1), 70 (PB1), 5 (PB50) Dune O ✓"""]]
99 I'm going to attempt to work around it by moving to an external CSV. — [[Jon]]
101 > What version of Text::CSV (Debian: `libtext-csv-perl`) are you using?
102 > What version of Text::CSV::XS (Debian: `libtext-csv-xs-perl`) are you
105 > I could't reproduce this with `libtext-csv-perl_2.00-1` and
106 > `libtext-csv-xs-perl_1.39-1`, assuming that the whitespace in
107 > `delimiter="..."` was meant to be a literal tab character, and that
108 > the data row has literal tabs before Dune, before O and before ✓.
110 > It would be great if you could modify `t/table.t` to include a failing
111 > test-case, and push it to your github fork or something, so I can apply
112 > it without having to guess precisely what the whitespace should be.
115 >> Sorry, I appreciate as bug reports go my last post was not that useful.
116 >> It's serving as a sort-of personal placeholder to investigate further.
117 >> The issue can be seen live [here](https://jmtd.net/fiction/sf_masterworks/),
118 >> the source is [here](https://jmtd.net/tmp/sf_masterworks.mdwn). The web
119 >> servers versions are ikiwiki 3.20190228-1,
120 >> libtext-csv-perl 1.33-2 and libtext-csv-xs-perl is not installed.
121 >> I'll do some futher diagnosis and poking around.