]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/commit
Try revert operations (on a branch) before approving them
authorSimon McVittie <smcv@debian.org>
Mon, 26 Dec 2016 18:45:02 +0000 (18:45 +0000)
committerSimon McVittie <smcv@debian.org>
Wed, 11 Jan 2017 19:55:09 +0000 (19:55 +0000)
commit9b3c1867c8fb53c73cdad85dc73578261df481af
treef95b9eb974dbd26aab9f2a7ff1c898f5301f46e7
parentf32f6411ff604a879151ab329907afca351ea3b6
Try revert operations (on a branch) before approving them

Otherwise, we have a time-of-check/time-of-use vulnerability:
rcs_preprevert previously looked at what changed in the commit we are
reverting, not at what would result from reverting it now. In
particular, if some files were renamed since the commit we are
reverting, a revert of changes that were within the designated
subdirectory and allowed by check_canchange() might now affect
files that are outside the designated subdirectory or disallowed
by check_canchange().

OVE-20161226-0002
IkiWiki/Plugin/git.pm